[query] Deprecate hl.null in favor of hl.missing#9936
Merged
danking merged 6 commits intohail-is:mainfrom Jan 27, 2021
Merged
Conversation
danking
approved these changes
Jan 27, 2021
Contributor
danking
left a comment
danking
left a comment
There was a problem hiding this comment.
Awesome! Thank you JohN!
jmarshall
added a commit
to populationgenomics/hail
that referenced
this pull request
Apr 19, 2023
PR hail-is#9936 added hl.missing, which supersedes hl.null, and replaced instances of null(...) invocations in the documentation. However :func:`.null` instances in the surrounding text were missed.
danking
pushed a commit
that referenced
this pull request
Apr 21, 2023
https://hail.is/docs/0.2/overview/expressions.html#missingness says: > In Hail, all expressions can be missing. An expression representing a missing value of a given type can be generated with the [`null()`](https://hail.is/docs/0.2/functions/core.html#hail.expr.functions.null) function, which takes the type as its single argument. It then proceeds to show a number of examples, all of which use `missing()` rather than `null()`, which is confusing. PR #9936 added `hl.missing`, which supersedes `hl.null`, and replaced instances of `null(...)` invocations in the documentation. However `:func:'.null'` instances in the surrounding documentation text were missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG: Deprecated
hl.nullin favor ofhl.missing.Dan suggested that
hl.nullandhl.is_missingdidn't match well. Now it'shl.missingandhl.is_missing, which makes more sense.