From d4bee33fa4dff0070d83847fce754951fbd7f910 Mon Sep 17 00:00:00 2001
From: Robert Haines <rhaines@manchester.ac.uk>
Date: Sat, 20 Oct 2018 16:38:31 +0100
Subject: [PATCH] Test that an incorrectly stored mimetype is detected.

---
 test/data/bad_mimetype_offset.container | Bin 0 -> 352 bytes
 test/read_file_test.rb                  |  10 ++++++++++
 test/test_helper.rb                     |   1 +
 3 files changed, 11 insertions(+)
 create mode 100644 test/data/bad_mimetype_offset.container

diff --git a/test/data/bad_mimetype_offset.container b/test/data/bad_mimetype_offset.container
new file mode 100644
index 0000000000000000000000000000000000000000..f78903abcf05616a1b9119149da61282399b9c9a
GIT binary patch
literal 352
zcmWIWW@h1H0D-CqKi`&lFShUj*&xirAj6Pel$u(SnU}6tQc)5b!pXqgE^;_}r_Jf;
z(h6<{MwS=M3=CkxBQ+-{Uq>N4zbGd~kt+bj%>2aFIwC;xK$rt)W^QI~YDr~5Dn9cP
z3kq^FlM_oa^Yipm3rdr;t1=4$ycwC~m~pvP0%$q|10xV`X#}xQUCs(|Ihw1{O+<Am
bvWX!;6A|vlWg06R$Yv%WTmYn3fjA5R%kNEb

literal 0
HcmV?d00001

diff --git a/test/read_file_test.rb b/test/read_file_test.rb
index 84020e3..7bf7374 100644
--- a/test/read_file_test.rb
+++ b/test/read_file_test.rb
@@ -77,6 +77,16 @@ def test_verify_compressed_mimetype
     refute(ZipContainer::File.verify?(COMPRESSED_MIMETYPE))
   end
 
+  # Check that a container with an incorrectly stored mimetype is detected.
+  def test_verify_bad_mimetype_offset
+    assert_raises(ZipContainer::MalformedContainerError) do
+      ZipContainer::File.verify!(BAD_MIMETYPE_OFFSET)
+    end
+
+    refute(ZipContainer::File.verify(BAD_MIMETYPE_OFFSET).empty?)
+    refute(ZipContainer::File.verify?(BAD_MIMETYPE_OFFSET))
+  end
+
   # Check the raw mimetype bytes
   def test_raw_mimetypes
     empty_container = File.read(EMPTY_CONT)
diff --git a/test/test_helper.rb b/test/test_helper.rb
index 333920e..1a91311 100644
--- a/test/test_helper.rb
+++ b/test/test_helper.rb
@@ -50,5 +50,6 @@
 EMPTY_CONT = 'test/data/empty.container'.freeze
 EMPTY_ZIP = 'test/data/empty.zip'.freeze
 COMPRESSED_MIMETYPE = 'test/data/compressed_mimetype.container'.freeze
+BAD_MIMETYPE_OFFSET = 'test/data/bad_mimetype_offset.container'.freeze
 EXAMPLE = 'test/data/example.container'.freeze
 SUBCLASS = 'test/data/subclassed.container'.freeze