Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query plan with parallelism, VERBOSE and ANALYSE flags but no BUFFERS causes exception #12

Closed
hairybreeches opened this issue Jul 23, 2019 · 1 comment

Comments

@hairybreeches
Copy link
Owner

commented Jul 23, 2019

Failure to get buffers values from worker threads leads to a null reference exception.

There's a serious question here about how much time we should spend working on different combinations of flags, when we're supporting an experience that isn't as good as with the recommended flags.

Perhaps we should require all flags to be turned on?

@hairybreeches hairybreeches added the bug label Jul 23, 2019
@hairybreeches

This comment has been minimized.

Copy link
Owner Author

commented Jul 23, 2019

After discussing with @mchristofides , we've agreed to fix this issue since we want to make it easy for people to use the tool the first time.

We're going to add the recommended flags (FORMAT JSON, VERBOSE, BUFFERS, ANALYZE) to a few more messages (particularly errors returned when the input is not in JSON format or missing timings.

We do remain open to the idea of making these flags required though, particularly since there's a growing movement to turn the BUFFERS flag on by default.

Fixed in commit 97015ba3bc052acdd28b3adb69388432b3436f40 , deployed at 13:16, 23/07/2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.