Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request fails when local storage limit reached #7

Closed
hairybreeches opened this issue Jun 27, 2019 · 1 comment

Comments

@hairybreeches
Copy link
Owner

commented Jun 27, 2019

When the browser local storage size limit is reached, the result from the server cannot be stored and the operation fails.

This means the result page cannot be loaded and the loading spinny carries on forever.

The default storage space is quite large relative to the result size - I have just hit this issue for the second time, after 8 months of spamming examples every hour of every day - so it's probably a while before someone hits this while properly using the product.

However, we also need to balance the need to make results available to preserve history/navigation against being rude by taking up to much browser storage.

@hairybreeches

This comment has been minimized.

Copy link
Owner Author

commented Jul 3, 2019

Fix: keep a record of all results, keep the last 15 and get rid of any older results

Fixed in commit 13adfcdeb57b60cbffcbc7c3ee7d3a550ad29836, deployed at 9:03 03/07/19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.