New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider to have a number for each layer #54

Open
area73 opened this Issue May 22, 2017 · 4 comments

Comments

Projects
None yet
5 participants
@area73
Contributor

area73 commented May 22, 2017

I know that you discuss these already but I think is a nice idea to have the numbers in layer's name, specially that you have now many of them

@danifornells

This comment has been minimized.

Collaborator

danifornells commented Jun 3, 2017

After a while using the project, we did not found cases where new layer additions can break the numeration, so let's vote again for that. My suggestion is to use tens for the layer group and alphabet for the layer itself, according haiticss triangle:

  • 0x config
  • 1x base
  • 2x abstractions
  • 3x content
  • 9x overrides

The result should look like:

  • 0a_settings
  • 0b_foundations
  • 0c_tools
  • 1a_generic
  • 1b_elements
  • 1c_material
  • 2a_objects
  • 2b_animations
  • 2c_color-schemes
  • 9a_scopes
  • 9z_utilities

Please, use thumb up & down reactions to vote this, or feel free to add your proposal.
Knock knock @area73 @judabelli @arnau-pujol @d-asensio @nucliweb @dslara

@d-asensio

This comment has been minimized.

Contributor

d-asensio commented Jun 3, 2017

I find it messy, I prefer to keep it as is now. It's an important choice, so we can not change it easily (a user already using haiticss will be forced to change imports in it's project), besides that, I think it's better to document it well than prefixing folders to get the desired sorting. And even more, we're assuming an alphabetical sorting but what if the consumer use date sorting for it's project.

To not to prefix folders it's more flexible 😄

But just my opinion!

@arnau-pujol

This comment has been minimized.

Contributor

arnau-pujol commented Jun 5, 2017

In my opinion, the numbers/letters combination is a little bit strange and chaotic.

The numbers used to be quite well, but I think that are not actually needed. Taking a look at this image the layers order is crystal-clear and, after a while working with them, you can remember the order easily (or check it again).

My vote is the same as @d-asensio: Keep the layers name with no prefix.

@judabelli

This comment has been minimized.

Contributor

judabelli commented Jun 6, 2017

I think that prefixes could be useful. It's true that people can check the inverted triangle image wherever they want to check the order, but why not make it clear directly? We can see the order directly in the code editor, and I that would be more friendly for HaitiCSS users. So why not?

That's my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment