New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept close event instead of ignoring it #988

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@eplightning
Copy link

eplightning commented Oct 8, 2017

Ignoring main window close event causes weird behavior as described in the forum post: https://forum.seafile.com/t/plasma-logout-canceled-by-seafile-applet/3283

VLC used to have similar issue: https://trac.videolan.org/vlc/ticket/4606

This PR replaces ignore() call with accept() which fixes that issue. I haven't noticed any problems with exit-to-tray feature. Tested on Arch Linux.

@lins05 lins05 force-pushed the haiwen:master branch from c569d07 to 90c4bb3 Oct 28, 2017

@bionade24

This comment has been minimized.

Copy link

bionade24 commented Dec 17, 2018

What's now with this patch and its related forum thread?

@moschlar

This comment has been minimized.

Copy link
Contributor

moschlar commented Jan 10, 2019

FYI: I've added the patch to the package in the Debian repositories.

@bionade24

This comment has been minimized.

Copy link

bionade24 commented Jan 10, 2019

Perfect I'll test it. If working, I'll make a pull request with the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment