New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move on folder with ignored files results in data loss #1383

Closed
KenN7 opened this Issue Sep 16, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@KenN7
Copy link

KenN7 commented Sep 16, 2015

Hi,

I just found myself in a very unconfortable situation.

Say you create a library A, synced on /home/me/A/ and a second one named B on /home/me/B/.
You add a folder to lib A named "foo" containing 2 files, "file.txt" and "file.big".

I create an ignore file containing :
*.big

So A contains : /home/me/A/
/home/me/A/seafile-ignore.txt
/home/me/A/foo/
/home/me/A/foo/file.txt
/home/me/A/foo/file.big

So only file.txt is synced online and you can access it on seahub, so far, it's ok.

Say now that a want to move folder "foo" to library B, without resyncing, so I go on seahub
and click on "Move" button of the webinterface.

Now the unfortunate part :
Folder "foo" will be moved from A to B, resulting the client to delete folder "foo" in library A an,d create and sync folder "foo" on library B, problem is that "file.big" gets deleted in the process of moving ! The client deletes the moved folder from lib A without carring about ignored files !

Thanks,
Regards

@killing

This comment has been minimized.

Copy link
Member

killing commented Sep 16, 2015

Yes this is a bug. We should check the ignore list when deleting the
content of a folder.

2015-09-16 15:59 GMT+08:00 Ken notifications@github.com:

Hi,

I just found myself in a very unconfortable situation.

Say you create a library A, synced on /home/me/A/ and a second one named B
on /home/me/B/.
You add a folder to lib A named "foo" containing 2 files, "file.txt" and
"file.big".

I create an ignore file containing :
*.big

So A contains : /home/me/A/
/home/me/A/seafile-ignore.txt
/home/me/A/foo/
/home/me/A/foo/file.txt
/home/me/A/foo/file.big

So only file.txt is synced online and you can access it on seahub, so far,
it's ok.

Say now that a want to move folder "foo" to library B, without resyncing,
so I go on seahub
and click on "Move" button of the webinterface.

Now the unfortunate part :
Folder "foo" will be moved from A to B, resulting the client to delete
folder "foo" in library A an,d create and sync folder "foo" on library B,
problem is that "file.big" gets deleted in the process of moving ! The
client deletes the moved folder from lib A without carring about ignored
files !

Thanks,
Regards


Reply to this email directly or view it on GitHub
#1383.

@freeplant

This comment has been minimized.

Copy link
Member

freeplant commented Nov 25, 2015

It is fixed in v5.0.0.

@freeplant freeplant closed this Nov 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment