New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Perl::Critic violations in tests #24

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@paultcochrane

paultcochrane commented May 6, 2017

The test files were not adhering to the Perl::Critic standards that the rest of the code is kept to (via the critic.t tests). These changes bring the test files up to the same best practices standard and allow the test files to also be checked for Perl::Critic violations.

This PR is submitted in the hope that it is useful. If it can be improved upon in any way, please just let me know and I'll update and resubmit as necessary.

paultcochrane added some commits May 6, 2017

Use Class::Load to check for available test modules
... which allows one to avoid a string evaluation in order to check that
a given test module is available or not for the POD and Perl::Critic
tests.  Although this does add one extra dependency for the
distribution, it makes the test code adhere to the same Perl best
practices that the main code is held to.  This change also paves the way
for the test files to be checked as part of the `critic.t` tests.

@paultcochrane paultcochrane changed the title from Fix Per::Critic violations in tests to Fix Perl::Critic violations in tests May 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment