New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked unit tests for better test coverage. #9

Merged
merged 2 commits into from Jan 26, 2015

Conversation

Projects
None yet
2 participants
@geofffranks
Contributor

geofffranks commented Jan 26, 2015

Now uses Test::Fake::HTTPD to verify that the data
input into WebService::Pushover is what we want to
get sent to the remote server. As a side-effect, this
also gives us testing of the API contract that
WebService::Pushover provides to end-users.

This required some changes to Pushover.json, since
the documentation for Net::HTTP::Spore wasn't good enough
to determine how to change per-method base_url values for
testing.

geofffranks added some commits Jan 26, 2015

Reworked unit tests for better test coverage.
Now uses Test::Fake::HTTPD to verify that the data
input into WebService::Pushover is what we want to
get sent to the remote server. As a side-effect, this
also gives us testing of the API contract that
WebService::Pushover provides to end-users.

This required some changes to Pushover.json, since
the documentation for Net::HTTP::Spore wasn't good enough
to determine how to change per-method base_url values for
testing.

hakamadare added a commit that referenced this pull request Jan 26, 2015

Merge pull request #9 from geofffranks/testing_improvements
Reworked unit tests for better test coverage.

@hakamadare hakamadare merged commit 54d06e7 into hakamadare:master Jan 26, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details
@hakamadare

This comment has been minimized.

Show comment
Hide comment
@hakamadare

hakamadare Jan 26, 2015

Owner

fixed a dependency in Build.PL that was making Travis unhappy

Owner

hakamadare commented Jan 26, 2015

fixed a dependency in Build.PL that was making Travis unhappy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment