Skip to content

Support: Windows OS.#116

Merged
hakancelikdev merged 18 commits into
hakancelikdev:masterfrom
hadialqattan:i110
Sep 26, 2020
Merged

Support: Windows OS.#116
hakancelikdev merged 18 commits into
hakancelikdev:masterfrom
hadialqattan:i110

Conversation

@hadialqattan
Copy link
Copy Markdown
Contributor

Solve both #110 and #104 .

@hadialqattan
Copy link
Copy Markdown
Contributor Author

Hi @hakancelik96 , all tests passed except the pre-commit hooks!

I think there's a problem with the pre-commit hooks!

@hadialqattan
Copy link
Copy Markdown
Contributor Author

Hi @hakancelik96 , all tests passed except the pre-commit hooks!

I think there's a problem with the pre-commit hooks!

I don't know where the problem is, but black on the pre-commit (locally) runs with the default args (--line-length=88) instead of (--line-length=79)!

I've blackened the PR by running black . --line-length=79 manually, and as you see everything is fine!

@hadialqattan
Copy link
Copy Markdown
Contributor Author

hadialqattan commented Sep 25, 2020

Anyway, the Windows OS has supported!

I'm waiting for your reviews!
@hakancelik96
@isidentical

@hadialqattan
Copy link
Copy Markdown
Contributor Author

@hakancelik96 kindly please link this PR to #110 and #104

Comment thread tests/test_scanner.py
Comment thread tests/test_session.py Outdated
Comment thread tests/test_session.py Outdated
@hakancelikdev
Copy link
Copy Markdown
Owner

Why does Codecov not work when a non-member of the repo send a PR? Do you have any idea

@hadialqattan
Copy link
Copy Markdown
Contributor Author

Why does Codecov not work when a non-member of the repo send a PR? Do you have any idea

Unfortunately, I don't have any idea, but I'll try to solve it as soon as I have enough time for that.

@hakancelikdev
Copy link
Copy Markdown
Owner

Thank you for your great contribution 💯

@hakancelikdev hakancelikdev merged commit 5c21397 into hakancelikdev:master Sep 26, 2020
@hadialqattan hadialqattan deleted the i110 branch September 26, 2020 15:02
@hakancelikdev
Copy link
Copy Markdown
Owner

hakancelikdev commented Sep 27, 2020

Why does Codecov not work when a non-member of the repo send a PR? Do you have any idea

Unfortunately, I don't have any idea, but I'll try to solve it as soon as I have enough time for that.

@hadialqattan codecov/codecov-action#29

hakancelikdev pushed a commit that referenced this pull request Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding WindowsOS to the CI pipeline. diff option should produce a usable patch

2 participants