Skip to content

Support for type hints #58 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hakancelikdev merged 17 commits into from
Jul 20, 2020
Merged

Support for type hints #58 #71

hakancelikdev merged 17 commits into from
Jul 20, 2020

Conversation

@hakancelikdev
Copy link
Owner

@hakancelikdev hakancelikdev commented Jul 11, 2020

No description provided.

@hakancelikdev hakancelikdev marked this pull request as draft July 11, 2020 18:10
Repository owner deleted a comment from codecov bot Jul 14, 2020
@hakancelikdev hakancelikdev linked an issue Jul 16, 2020 that may be closed by this pull request
Support for type hints #58
Closed
@codecov
Copy link

codecov bot commented Jul 19, 2020 •
edited
Loading

Codecov Report

Merging #71 into master will decrease coverage by 0.92%.
The diff coverage is 85.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   86.95%   86.02%   -0.93%     
==========================================
  Files          12       14       +2     
  Lines         897      959      +62     
==========================================
+ Hits          780      825      +45     
- Misses        117      134      +17
Impacted Files Coverage Δ
unimport/__main__.py 0.00% <0.00%> (ø)
unimport/models.py 0.00% <0.00%> (ø)
unimport/refactor.py 96.15% <92.30%> (-1.07%) ⬇️
unimport/scan.py 98.35% <98.36%> (-0.40%) ⬇️
tests/test_config.py 100.00% <100.00%> (ø)
tests/test_refactor.py 100.00% <100.00%> (ø)
unimport/__init__.py 100.00% <100.00%> (ø)
unimport/color.py 54.54% <100.00%> (ø)
unimport/config.py 94.73% <100.00%> (-0.62%) ⬇️
unimport/relate.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af28660...8746b31. Read the comment docs.

@hakancelikdev hakancelikdev force-pushed the i58 branch 4 times, most recently from 5d27642 to 38e5cbc Compare July 19, 2020 21:08
@hakancelikdev hakancelikdev marked this pull request as ready for review July 20, 2020 08:42
@hakancelikdev hakancelikdev merged commit e014485 into master Jul 20, 2020
@hakancelikdev hakancelikdev deleted the i58 branch July 20, 2020 21:35
hakancelikdev added a commit that referenced this pull request Jul 16, 2022
@hakancelikdev
Support for type hints #58 (#71)
12a5573 
* color.py

* config.py

* refactor.py

* Bug fix: Config in session

* Fixed wrong typing in refactor.py

* scan.py & string typing support

* update docs

* session.py

* string function return type improve

* fix string function return type & mypy fix

* __main__.py

* relate.py

* v0.2.8

* import error fix & unused recursive remove & libcst update

* fix: typing when args became str

* fix version in changelog

* unnecessary typing remove
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkmngrgn gkmngrgn Awaiting requested review from gkmngrgn

@isidentical isidentical Awaiting requested review from isidentical

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for type hints

2 participants

@hakancelikdev