Configurable / custom key bindings #149

Closed
nateabele opened this Issue Sep 24, 2012 · 2 comments

Comments

Projects
None yet
2 participants

Hey, first of all, thanks for sharing such an awesome library!

I'm working on a presentation involving some interactive content with input elements, and having reveal.js respond to non-arrow keys causes slides to jump around when entering text.

I started to just hack around it, but if you think it's worthwhile, I'd be happy to write a PR to make the keyboard option take something other than a boolean.

Thanks again for your time.

Owner

hakimel commented Sep 25, 2012

Keyboard shortcuts should be automatically disabled when an input element is focused. I just re-tested and it works on a standard <input type=text> but perhaps there are other cases, or browsers, where it doesn't. This is where the check is:

https://github.com/hakimel/reveal.js/blob/master/js/reveal.js#L346

Ah, serves me right for not testing against HEAD. :-) Thanks!

@nateabele nateabele closed this Sep 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment