Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show resume on pause if controls enabled #2215

Merged
merged 1 commit into from Aug 16, 2018

Conversation

@anderslemke
Copy link
Contributor

anderslemke commented Aug 15, 2018

Hi @hakimel ,

This is such an awesome project! Thank you for making it 馃憦

I really love the idea of the pause-mode.
I'm not a big fan of the "Resume presentation"-button though... 馃き

I tried figuring out why it was introduced, but I couldn't.

So in this PR I'm proposing two things:

  1. Use config.controls to control whether or not the button is shown.
  2. Let the entire dom.pauseOverlay listen for clicks and close when clicked.

This is just one way you could approach this. You could also introduce a new config for the button, but I thought it made good sense to use the controls.

Let me know what you think.

@hakimel hakimel merged commit b003a54 into hakimel:dev Aug 16, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hakimel

This comment has been minimized.

Copy link
Owner

hakimel commented Aug 16, 2018

Both changes make sense 鈥 thanks!

The resume button was added because some people were accidentally triggering the pause mode and getting stuck without knowing how to disable it.

@anderslemke

This comment has been minimized.

Copy link
Contributor Author

anderslemke commented Aug 16, 2018

Ah, yes of course. That makes sense. "Where the 馃が did my presentation just go?" 馃お

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.