Skip to content

Fabian Becker halfdan

Developer Program Member

Organizations

Piwik Open Source Analytics geekproject Ghost
halfdan commented on issue TryGhost/Ghost#3160
Fabian Becker

The location value is currently ignored and not handled properly. This is probably easy to fix with some CSS. /cc @pauladamdavis On 8 Jul 2014 15:3…

halfdan commented on issue TryGhost/Ghost#3160
Fabian Becker

Notification have a location field that can be used for the update notification. Check out the notifications API. On 8 Jul 2014 06:11, "Jason Willi…

halfdan commented on issue TryGhost/Ghost#3160
Fabian Becker

Shouldn't this just be a server side notifications.add? I don't think we need to introduce a new API endpoint for this. Am I missing something? On …

halfdan commented on issue TryGhost/Ghost#3175
Fabian Becker

@novaugust @kevinansfield What is the benefit/advantage of doing that? From a very subjective point of view a this.send('notification', ...) looks …

halfdan commented on issue TryGhost/Ghost#3187
Fabian Becker

Prohibit slugs from being the same format as ids. For example by adding -post if the slug is numeric. I very strongly need to disagree on that. W…

halfdan commented on issue TryGhost/Ghost#3100
Fabian Becker

IMHO user deletion should perform soft-deletes. On 2 Jul 2014 10:35, "Gabor Javorszky" notifications@github.com wrote: Couple of questoins: What h…

halfdan commented on pull request TryGhost/Ghost#3149
Fabian Becker

@kevinansfield In the old admin the email notification was DELETEd when the user closed the notification. It should not reappear. Ghost works fine …

halfdan commented on commit javorszky/Ghost@6862e55e49
Fabian Becker

/*jshint unused:true*/ Any reason to keep it as TODO?

halfdan commented on commit javorszky/Ghost@6862e55e49
Fabian Becker

You can use /*jshint unused:true*/

halfdan commented on commit javorszky/Ghost@6862e55e49
Fabian Becker

This is where JSON-API gets a bit odd. There’s no passwordreset entity anywhere. Not sure if I like how the document is structured here.

halfdan commented on commit javorszky/Ghost@6862e55e49
Fabian Becker

@sebgie Will we still need that with OAuth merged?

halfdan commented on pull request TryGhost/Ghost#3149
Fabian Becker

It is from the server side - location and dismissible will be used to place notifications at different places on the screen, dismissible is self-ex…

halfdan commented on pull request TryGhost/Ghost#3149
Fabian Becker

Would it make more sense for the injected Notifications object to work directly with Notification model instances? That is a very good question. …

halfdan commented on issue TryGhost/Ghost#2465
Fabian Becker

How should permissions work then? Destroy effectively edits the status and sets it to deleted - which could also be achieved by editing the app. Sh…

halfdan commented on pull request goinstant/ouija#70
Fabian Becker

That looks fantastic!

halfdan deleted branch 2850-post-notifications at halfdan/Ghost
halfdan commented on issue TryGhost/Ghost#2465
Fabian Becker

I need some clarification here. Since we are soft-deleting apps, which effectively means editing the status of the app to 'deleted' I am not sure w…

Fabian Becker
Publish 0.7.0 on npm
Fabian Becker
halfdan commented on commit jaswilli/Ghost@feddb0de98
Fabian Becker

If there’s an error, then that should be returned. Calling sendTest with req, res will not work - typo?

halfdan commented on commit jaswilli/Ghost@feddb0de98
Fabian Becker

Sorry to complain again, but I think this does now not comply to JSON-API :-/

halfdan commented on issue TryGhost/Ghost#3130
Fabian Becker

That is an issue that should be fixed upstream IMHO, an issue exists at bower/bower#1338

halfdan commented on pull request TryGhost/Ghost#3129
Fabian Becker

As mentioned in IRC, the sendTest endpoint was intentionally introduced in #2550 to also allow apps to send test mails.

halfdan commented on commit jaswilli/Ghost@e414c893f4
Fabian Becker

You can just call api.mail.send directly here - why the indirection?

halfdan commented on issue TryGhost/Ghost#3123
Fabian Becker

Maybe you're just being rude, but since that isn't how we do things on github This is how we do things on Github. You have not shown us a way of …

halfdan commented on issue TryGhost/Ghost#3126
Fabian Becker

Hello @doomdagger, we are in the middle of switching over to Ember. The old admin is not supposed to work and will be removed shortly. The new admi…

halfdan commented on issue TryGhost/Ghost#3121
Fabian Becker

@thany This is very specific to your linux distribution - all other linux distributions I know of have the node binary as node and not as nodejs.

halfdan commented on issue TryGhost/Ghost#3121
Fabian Becker

Again. This is not an issue with Ghost. The installer is npm, which is a dependency manager for node. This however is most likely an issue with the …

halfdan commented on issue TryGhost/Ghost#3121
Fabian Becker

@thany It isn’t an error with Ghost, it is one with your setup. Please check whether you can start node with node or nodejs. If only the latter wor…

halfdan deleted branch 3072-setup-screen at halfdan/Ghost
Something went wrong with that request. Please try again.