Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External code is not fully implemented for GPU devices and source code backends. #1971

Open
zvookin opened this issue Apr 4, 2017 · 0 comments
Open

External code is not fully implemented for GPU devices and source code backends. #1971

zvookin opened this issue Apr 4, 2017 · 0 comments

Comments

@zvookin
Copy link
Member

zvookin commented Apr 4, 2017

The API design for ExternalCode allows providing source code for various GPU backend compute languages and C++ code for the C++ backend. (And JavaScript eventually.) However this is not fully plumbed through. It is also not covered by tests.
dsharletg added a commit that referenced this issue Feb 26, 2021
@dsharletg
Offload GPU code in a lowering pass instead of via CodeGen_GPU_Host. F…
041b9fe 
…ixes #5650, fixes #2797, fixes #2084, now #1971 is more relevant.
@dsharletg dsharletg mentioned this issue Feb 27, 2021
Merged
dsharletg added a commit that referenced this issue Mar 2, 2021
@dsharletg @steven-johnson
Move CodeGen_GPU_Host to a lowering pass (#5775)
7493c09 
* Remove unused vertex buffer parameters.

* Offload GPU code in a lowering pass instead of via CodeGen_GPU_Host. Fixes #5650, fixes #2797, fixes #2084, now #1971 is more relevant.

* clang-format.

* clang-format sorting is case sensitive!?

* clang-tidy

* Pass type arguments correctly.

* Update OffloadGPULoops.cpp

* trigger buildbots

* Hack around tests that rely on the IR for offloaded GPU loops.

* clang-tidy

* Use custom lowering pass to see code before GPU offloading

* Speculative fix for segfault

* Fix const correctness

* Fix error on unused variables in generated code.

* Remove unnecessary space

* Use helper.

Co-authored-by: Steven Johnson <srj@google.com>
dsharletg added a commit that referenced this issue Mar 4, 2021
@dsharletg @steven-johnson
Move codegen backends into anonymous namespaces in source files and d…
06b208f 
…on't build them if not enabled (#5776)

* Remove unused vertex buffer parameters.

* Offload GPU code in a lowering pass instead of via CodeGen_GPU_Host. Fixes #5650, fixes #2797, fixes #2084, now #1971 is more relevant.

* clang-format.

* clang-format sorting is case sensitive!?

* clang-tidy

* Move codegen backends into anonymous namespaces in source files.

* clang-format

* Pass type arguments correctly.

* Update OffloadGPULoops.cpp

* trigger buildbots

* trigger buildbots

* Hack around tests that rely on the IR for offloaded GPU loops.

* Fix missing include.

* Remove unused include.

* clang-tidy

* Use custom lowering pass to see code before GPU offloading

* Speculative fix for segfault

* Fix const correctness

* Fix error on unused variables in generated code.

Co-authored-by: Steven Johnson <srj@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zvookin