Improve number display

[halivert]

Description

We need to improve the display of numbers so user can easily view the difference between the tens, hundreds, thousands and so on

Acceptance criteria

The display must have a comma when a group of three numbers (before decimal point) is displayed

Examples

[YashJain2409]

Can i work on this?

[halivert]

Sure @YashJain2409 👍🏽

[YashJain2409]

Hey @halivert , i have created pr ,you can review it.

[dpuentel]

This doesn't work as expected.

• Input "9999" the app show "9999" when it should be "9.999".
• Input "99999" the app show "99.999" when ir should be "99,999".

The dot, only there be to decimals otherwise the result will be unexpected

[halivert]

Hey @dpuentel, maybe the locale of your browser is different because this is implemented with toLocaleString so the PR solution is better than the described one, thank you anyway

[dpuentel]

Hey @dpuentel, maybe the locale of your browser is different because this is implemented with toLocaleString so the PR solution is better than the described one, thank you anyway

My browser locale is 'es-ES'.

However, the locale should not influence the result of the operations, and with locale 'es-ES' it is not working correctly.

The locale 'es-ES' uses '.' to separate thousands. This causes an error interpreting it as decimals.

Check 2ad3058, which doesn't affect the values for the calculation, only the display, and also forces the locale to 'en'

[halivert]

Yes @dpuentel you're right, what do you think of change the decimal point in the keyboard instead?

[YashJain2409]

@halivert Can you explain issue you are getting ?

[halivert]

Yes @YashJain2409, when you try to use the locale string with locales that use decimal coma, instead decimal point, some issues arise because the point in the calculator keyboard doesn't change.

I hope @dpuentel can upload a gif or screenshot showing us the actual issue.

[dpuentel]

Yes @YashJain2409, when you try to use the locale string with locales that use decimal coma, instead decimal point, some issues arise because the point in the calculator keyboard doesn't change.

I hope @dpuentel can upload a gif or screenshot showing us the actual issue.

Of course. Here are some examples:

[YashJain2409]

ok got it thanks for explaining