New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleaned, italian translation, twitter button #3

Merged
merged 5 commits into from Dec 30, 2014

Conversation

Projects
None yet
2 participants
@Mte90

Mte90 commented Dec 29, 2014

I've added a button that open a popup for send a tweet with the simplebug link, the italian translation and i've added a reset.css for a better ui.
Also i've added the simplebug link near the bugzilla link.

@Mte90

This comment has been minimized.

Show comment
Hide comment
@Mte90

Mte90 Dec 29, 2014

The text in the twitter opopup is not translated because i've not understand how work that translation system.

Mte90 commented Dec 29, 2014

The text in the twitter opopup is not translated because i've not understand how work that translation system.

@hallvors hallvors merged commit 53b2c89 into hallvors:master Dec 30, 2014

@hallvors

This comment has been minimized.

Show comment
Hide comment
@hallvors

hallvors Dec 30, 2014

Owner

@Mte90 thanks for the changes. This review page started as a throwaway experiment and all of a sudden it's received two translations and code contributions :-D

Regarding the Twitter message, just add an entry to translationdictionary.js with the English text as the key and the Italian as the value. I've added a __() call that will translate the text if a translated string exists. (The homebrew-ish translation system is quite possibly too simplistic - I guess I should move to L20n or something).

(I had to do some manual merging here because I've been lazy pushing to Github. Entirely my fault. Make sure you pull the latest version, should be up-to-date now.)

Owner

hallvors commented Dec 30, 2014

@Mte90 thanks for the changes. This review page started as a throwaway experiment and all of a sudden it's received two translations and code contributions :-D

Regarding the Twitter message, just add an entry to translationdictionary.js with the English text as the key and the Italian as the value. I've added a __() call that will translate the text if a translated string exists. (The homebrew-ish translation system is quite possibly too simplistic - I guess I should move to L20n or something).

(I had to do some manual merging here because I've been lazy pushing to Github. Entirely my fault. Make sure you pull the latest version, should be up-to-date now.)

@Mte90

This comment has been minimized.

Show comment
Hide comment
@Mte90

Mte90 Dec 30, 2014

Perfect, online is missing the style.css so the layout is corrupted.

Mte90 commented Dec 30, 2014

Perfect, online is missing the style.css so the layout is corrupted.

@hallvors

This comment has been minimized.

Show comment
Hide comment
@hallvors

hallvors Dec 30, 2014

Owner

Ugh. Stackato problem. Fixing now.

Owner

hallvors commented Dec 30, 2014

Ugh. Stackato problem. Fixing now.

@Mte90

This comment has been minimized.

Show comment
Hide comment
@Mte90

Mte90 Dec 30, 2014

uhm i've see now that the text is not fully translated, also in spanish but i have not changed nothing of the translation system.

Mte90 commented Dec 30, 2014

uhm i've see now that the text is not fully translated, also in spanish but i have not changed nothing of the translation system.

@hallvors

This comment has been minimized.

Show comment
Hide comment
@hallvors

hallvors Dec 30, 2014

Owner

There was a new string or two in the code I had forgotten to commit, sorry
:-(

On Tue, Dec 30, 2014 at 7:38 PM, Daniele Scasciafratte <
notifications@github.com> wrote:

uhm i've see now that the text is not fully translated, also in spanish
but i have not changed nothing of the translation system.


Reply to this email directly or view it on GitHub
#3 (comment)
.

Owner

hallvors commented Dec 30, 2014

There was a new string or two in the code I had forgotten to commit, sorry
:-(

On Tue, Dec 30, 2014 at 7:38 PM, Daniele Scasciafratte <
notifications@github.com> wrote:

uhm i've see now that the text is not fully translated, also in spanish
but i have not changed nothing of the translation system.


Reply to this email directly or view it on GitHub
#3 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment