Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Refactor attachment detail modal#375

Merged
ruibaby merged 7 commits intohalo-dev:masterfrom
ruibaby:refactor/attachment-detail-modal
Nov 16, 2021
Merged

Refactor attachment detail modal#375
ruibaby merged 7 commits intohalo-dev:masterfrom
ruibaby:refactor/attachment-detail-modal

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 13, 2021

@auto-assign auto-assign bot requested review from JohnNiang, LIlGG and guqing November 13, 2021 10:32
@ruibaby ruibaby marked this pull request as draft November 13, 2021 10:32
@ruibaby ruibaby added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 13, 2021
@ruibaby ruibaby added this to the 1.5.x milestone Nov 13, 2021
@ruibaby ruibaby marked this pull request as ready for review November 14, 2021 03:44
@guqing
Copy link
Member

guqing commented Nov 14, 2021

image
当没有上一项或下一项时,区分一下状态,例如颜色灰色会不会好一点

@ruibaby ruibaby merged commit 2939cbb into halo-dev:master Nov 16, 2021
@guqing
Copy link
Member

guqing commented Nov 16, 2021

/lgtm

@ruibaby ruibaby deleted the refactor/attachment-detail-modal branch November 16, 2021 14:22
@ruibaby ruibaby mentioned this pull request Feb 21, 2022
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
* refactor: attachment detail modal

* refactor: attachment media type judgment

* refactor: pagination

* refactor: delete AttachmentDetailDrawer.vue

* refactor: remove unnecessary code

* perf: previous and next button state
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/feature Categorizes issue or PR as related to a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants