Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 24, 2022

  • add AttachmentSelectModal
  • remove AttachmentSelectDrawer
  • remove AttachmentDrawer

Signed-off-by: Ryan Wang i@ryanc.cc

Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 24, 2022
@ruibaby ruibaby added this to the 1.5.x milestone Jan 24, 2022
@auto-assign auto-assign bot requested review from JohnNiang, LIlGG and guqing January 24, 2022 08:44
@ruibaby ruibaby marked this pull request as draft January 24, 2022 08:44
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby marked this pull request as ready for review January 25, 2022 05:29
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby merged commit ae6968d into halo-dev:master Jan 25, 2022
@ruibaby ruibaby deleted the refactor/attachment-select-modal branch January 25, 2022 07:26
@ruibaby ruibaby mentioned this pull request Feb 21, 2022
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
* refactor: attachment selection modal

Signed-off-by: Ryan Wang <i@ryanc.cc>

* feat: support view attachment detail

Signed-off-by: Ryan Wang <i@ryanc.cc>

* chore: remove AttachmentSelectDrawer.vue

Signed-off-by: Ryan Wang <i@ryanc.cc>

* chore: remove AttachmentDrawer.vue

Signed-off-by: Ryan Wang <i@ryanc.cc>

* perf: add selected icon

Signed-off-by: Ryan Wang <i@ryanc.cc>

* perf: add search form

Signed-off-by: Ryan Wang <i@ryanc.cc>

* perf: support upload file

Signed-off-by: Ryan Wang <i@ryanc.cc>

* refactor: attachment selection modal

Signed-off-by: Ryan Wang <i@ryanc.cc>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/feature Categorizes issue or PR as related to a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants