Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@ZaneL1u
Copy link

@ZaneL1u ZaneL1u commented Mar 10, 2022

No description provided.

@auto-assign auto-assign bot requested review from JohnNiang, LIlGG, guqing and ruibaby March 10, 2022 11:05
@CLAassistant
Copy link

CLAassistant commented Mar 10, 2022

CLA assistant check
All committers have signed the CLA.

@ruibaby
Copy link
Member

ruibaby commented Mar 10, 2022

你好,此 PR 的提交似乎还包含了 #501 中的提交,建议按照下列操作重新推送:

git fetch upstream/master

git reset --soft upstream/master

git add .

git commit -a -s -m "fix: clear validation results while editing"

git push origin fix-clear-validate -f

另外,麻烦 sign 一下我们的 CLA,否则我们没有权限合并。#503 (comment)

@ZaneL1u ZaneL1u force-pushed the fix-clear-validate branch from da232b1 to 001fb36 Compare March 10, 2022 14:16
@ZaneL1u
Copy link
Author

ZaneL1u commented Mar 10, 2022

收到,已经提交,谢谢!

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZaneL1u ZaneL1u requested a review from guqing March 10, 2022 15:01
@ZaneL1u
Copy link
Author

ZaneL1u commented Mar 10, 2022

@guqing 点错了。。。不好意思哈

@ruibaby
Copy link
Member

ruibaby commented Mar 10, 2022

@guqing 点错了。。。不好意思哈

这是应该 request review 的,没有关系,可以随意 request。

@ruibaby ruibaby merged commit bb28b3f into halo-dev:master Mar 10, 2022
@ZaneL1u
Copy link
Author

ZaneL1u commented Mar 10, 2022

我也在学习使用GitHub,这是一件很酷的事情,我觉得这个博客非常好用,我会给朋友们安利的~
使用过程中发现什么问题我能解决的,我会尽一点点微薄之力~

谢谢你们~

@ZaneL1u ZaneL1u deleted the fix-clear-validate branch March 10, 2022 15:18
@guqing
Copy link
Member

guqing commented Mar 10, 2022

我也在学习使用GitHub,这是一件很酷的事情,我觉得这个博客非常好用,我会给朋友们安利的~
使用过程中发现什么问题我能解决的,我会尽一点点微薄之力~

谢谢你们~

非常感谢你对我们的肯定👍 期待你更多的贡献

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants