From aa9f84ea6f90de70b4ec8cfb5b7976f5b948659e Mon Sep 17 00:00:00 2001
From: AirboZH <i@airbozh.cn>
Date: Tue, 21 Nov 2023 14:28:07 +0800
Subject: [PATCH] Prevent private posts from being indexed when rebuilding
 index. (#4882)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. 如果这是你的第一次，请阅读我们的贡献指南：<https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md>。
1. If this is your first time, please read our contributor guidelines: <https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md>.
2. 请根据你解决问题的类型为 Pull Request 添加合适的标签。
2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request.
3. 请确保你已经添加并运行了适当的测试。
3. Ensure you have added or ran the appropriate tests for your PR.
-->

#### What type of PR is this?
/kind bug
<!--
添加其中一个类别：
Add one of the following kinds:

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind improvement

适当添加其中一个或多个类别（可选）：
Optionally add one or more of the following kinds if applicable:

/kind api-change
/kind deprecation
/kind failing-test
/kind flake
/kind regression
-->

#### What this PR does / why we need it:

在加入索引前判断文章的可见性。只将PUBLIC文章加入索引，修复手动刷新搜索索引会将私有文章加入索引的问题

#### Which issue(s) this PR fixes:
Fix #4879

<!--
PR 合并时自动关闭 issue。
Automatically closes linked issue when PR is merged.

用法：`Fixes #<issue 号>`，或者 `Fixes (粘贴 issue 完整链接)`
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
#### Special notes for your reviewer:

null

#### Does this PR introduce a user-facing change?

<!--
如果当前 Pull Request 的修改不会造成用户侧的任何变更，在 `release-note` 代码块儿中填写 `NONE`。
否则请填写用户侧能够理解的 Release Note。如果当前 Pull Request 包含破坏性更新（Break Change），
Release Note 需要以 `action required` 开头。
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->

```release-note
修复手动刷新搜索索引会将私有文章加入索引的问题
```
---
 .../main/java/run/halo/app/core/extension/content/Post.java   | 4 ++++
 .../src/main/java/run/halo/app/search/IndicesServiceImpl.java | 3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/api/src/main/java/run/halo/app/core/extension/content/Post.java b/api/src/main/java/run/halo/app/core/extension/content/Post.java
index fbb432edb5..ebe6b88603 100644
--- a/api/src/main/java/run/halo/app/core/extension/content/Post.java
+++ b/api/src/main/java/run/halo/app/core/extension/content/Post.java
@@ -81,6 +81,10 @@ public static boolean isPublished(MetadataOperator metadata) {
         return labels != null && parseBoolean(labels.getOrDefault(PUBLISHED_LABEL, "false"));
     }
 
+    public static boolean isPublic(PostSpec spec) {
+        return spec.getVisible() == null || VisibleEnum.PUBLIC.equals(spec.getVisible());
+    }
+
     @Data
     public static class PostSpec {
         @Schema(requiredMode = RequiredMode.REQUIRED, minLength = 1)
diff --git a/application/src/main/java/run/halo/app/search/IndicesServiceImpl.java b/application/src/main/java/run/halo/app/search/IndicesServiceImpl.java
index 9c52f60395..e2e3ae4203 100644
--- a/application/src/main/java/run/halo/app/search/IndicesServiceImpl.java
+++ b/application/src/main/java/run/halo/app/search/IndicesServiceImpl.java
@@ -40,7 +40,8 @@ public Mono<Void> rebuildPostIndices() {
 
     private Mono<Void> rebuildPostIndices(PostSearchService searchService) {
         return postFinder.listAll()
-            .filter(post -> Post.isPublished(post.getMetadata()))
+            .filter(
+                post -> Post.isPublished(post.getMetadata()) && Post.isPublic(post.getSpec()))
             .flatMap(listedPostVo -> {
                 PostVo postVo = PostVo.from(listedPostVo);
                 return postFinder.content(postVo.getMetadata().getName())