Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 请求被重定向至 /404 #186

Closed
5 of 7 tasks
GalvinGao opened this issue Jun 7, 2019 · 2 comments
Closed
5 of 7 tasks

404 请求被重定向至 /404 #186

GalvinGao opened this issue Jun 7, 2019 · 2 comments
Assignees
@JohnNiang
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@GalvinGao
Copy link
Contributor

GalvinGao commented Jun 7, 2019 •
edited

我确定我已经查看了 (标注[ ]为[x])

我要申请 (标注[ ]为[x])

  • BUG 反馈
  • 添加新的特性或者功能
  • 请求技术支持

Expected：根据 HTTP 规范，404 请求应直接返回 404 状态码，同时返回 HTML Body。
现情况：所有 404 请求将会被返回 302 状态码并被重定向至 /404
解决方案：所有 404 请求应直接返回 404 状态码，直接渲染并返回主题目录下的 /404.ftl

PS: 500 请求的情况也是一样
@JohnNiang JohnNiang added the kind/bug Categorizes issue or PR as related to a bug. label Jun 7, 2019
@JohnNiang JohnNiang self-assigned this Jun 7, 2019
@JohnNiang
Copy link
Member

谢谢您的反馈！

我们将尝试按照您所说的方案进行修改。

JohnNiang added a commit that referenced this issue Jun 7, 2019
@JohnNiang
Fix #186
3dc0a4e
@JohnNiang
Copy link
Member

已经修复此 bug，将于 v1.0.2 见面 ：P

ruibaby pushed a commit to ruibaby/halo that referenced this issue Jun 11, 2021
@JohnNiang
Fix halo-dev#186
8f1c696
JohnNiang pushed a commit to JohnNiang/halo that referenced this issue Mar 2, 2023
@BigBang019 @ruibaby
feat: add Theme Branches/Releases Control (halo issue 515&592) (halo-…
7b06be9 
…dev#186)

* halo issue 515&592

* beautify UI

Co-authored-by: Ryan Wang <i@ryanc.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnNiang JohnNiang

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GalvinGao @JohnNiang