Skip to content

fix: theme update by upload. - #1284

Merged
ruibaby merged 1 commit into
halo-dev:masterfrom
ruibaby:fix/theme-delete-and-upload
Feb 25, 2021
Merged

ruibaby merged 1 commit into
halo-dev:masterfrom
ruibaby:fix/theme-delete-and-upload

Conversation

@ruibaby

@ruibaby ruibaby commented Feb 24, 2021

Copy link
Copy Markdown
Member

No description provided.

@ruibaby ruibaby added the kind/bug Categorizes issue or PR as related to a bug. label Feb 24, 2021
@ruibaby ruibaby self-assigned this Feb 24, 2021
@ruibaby ruibaby added this to the 1.4.6 milestone Feb 24, 2021

@JohnNiang JohnNiang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是时候对 themeId 进行规范了。

@ruibaby

ruibaby commented Feb 24, 2021

Copy link
Copy Markdown
Member Author

是时候对 themeId 进行规范了。

嗯,我发现目前在 delete 请求,如果 themeId 是 run.halo.run.official 这种的话,themeId 只能取到 run.halo。另外使用安装包更新主题也会有请求方式不正确的问题。

@ruibaby
ruibaby merged commit 29466c5 into halo-dev:master Feb 25, 2021
@ruibaby
ruibaby deleted the fix/theme-delete-and-upload branch February 25, 2021 12:32
ruibaby added a commit to ruibaby/halo that referenced this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants