Mark email as not required parameter in BaseComment#1535
Merged
JohnNiang merged 12 commits intohalo-dev:masterfrom Nov 24, 2021
Merged
Mark email as not required parameter in BaseComment#1535JohnNiang merged 12 commits intohalo-dev:masterfrom
JohnNiang merged 12 commits intohalo-dev:masterfrom
Conversation
Closed
ruibaby
requested changes
Nov 18, 2021
src/main/java/run/halo/app/model/properties/CommentProperties.java
Outdated
Show resolved
Hide resolved
ruibaby
added
the
kind/feature
ruibaby
requested changes
Nov 18, 2021
ruibaby
approved these changes
Nov 18, 2021
JohnNiang
requested changes
Nov 19, 2021
Member
JohnNiang
left a comment
JohnNiang
left a comment
There was a problem hiding this comment.
Hi @jerry-shao , I suggest testing against comment API without providing email.
src/main/resources/migration/V5__migrate_remove_notnull_for_email_in_comments_table.sql
Outdated
Show resolved
Hide resolved
Contributor
Author
Good catch, a NPE got captured by adding more tests. |
guqing
approved these changes
Nov 20, 2021
src/test/java/run/halo/app/model/params/validation/PostCommentParamValidationTest.java
Outdated
Show resolved
Hide resolved
Member
|
/lgtm |
JohnNiang
reviewed
Nov 22, 2021
Member
JohnNiang
left a comment
JohnNiang
left a comment
There was a problem hiding this comment.
Hi @jerry-shao , I've left some comments below, please take a moment to look at them.
src/test/java/run/halo/app/controller/content/api/PostControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/run/halo/app/controller/content/api/PostControllerTest.java
Outdated
Show resolved
Hide resolved
Member
|
Thank @jerry-shao for your contribution! I'll look at the new IT test tomorrow carefully. BTW, please fix the check style conflicts first. |
JohnNiang
requested changes
Nov 24, 2021
Member
JohnNiang
left a comment
JohnNiang
left a comment
There was a problem hiding this comment.
Hi @jerry-shao , I've left one comment here. Everything is ok to me but this.
src/test/java/run/halo/app/controller/content/api/PostControllerTest.java
Outdated
Show resolved
Hide resolved
Member
|
LGTM |
JohnNiang
approved these changes
Nov 24, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark email as not required parameter in BaseComment
Tasks
Future work