New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: posts and pages cannot be counted for visits #3471
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3471 +/- ##
============================================
+ Coverage 61.46% 61.58% +0.11%
- Complexity 2477 2479 +2
============================================
Files 393 393
Lines 12570 12572 +2
Branches 1019 1019
============================================
+ Hits 7726 7742 +16
+ Misses 4355 4342 -13
+ Partials 489 488 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cherry-pick release-2.3 |
@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ruibaby: new pull request created: #3487 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #3471 /assign ruibaby ```release-note 修复文章和自定义页面缺失属性导致的访问量无法计数问题 ```
What type of PR is this?
/kind bug
/area core
/milestone 2.3.x
What this PR does / why we need it:
修复文章和自定义页面缺失 name 模型属性导致的访问量无法计数问题
此为 2.3.0 引入的问题 see #3300
how to test it?
/apis/api.halo.run/v1alpha1/trackers/counter
API 是否有如下参数,且 name 值正确Which issue(s) this PR fixes:
Fixes #3448
Does this PR introduce a user-facing change?