Repository navigation
feat: implement new mechanisms for generating and managing attachment thumbnails - #6454
Merged
Merged
Conversation
guqing
force-pushed
the
feature/2387
branch
5 times, most recently
from
August 12, 2024 08:31
08e46b2 to
aff1562
Compare
Member
|
如果不同的存储策略上传了同名的图片,生成缩略图会异常,所以建议 thumbnails 目录根据存储策略隔离。
日志: |
Member
Author
改了,这是个bug,之前做了检查的,但是检查的是文件名,应该检查 thumbnail 记录 |
guqing
marked this pull request as ready for review
August 14, 2024 03:08
guqing
marked this pull request as draft
August 14, 2024 09:13
guqing
force-pushed
the
feature/2387
branch
8 times, most recently
from
August 20, 2024 04:21
549a4cf to
22590c8
Compare
Member
|
/hold |
guqing
force-pushed
the
feature/2387
branch
5 times, most recently
from
August 26, 2024 08:40
70b1376 to
a60d0aa
Compare
Member
|
/unhold |
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What type of PR is this?
/kind feature
/area core
/milestone 2.19.x
What this PR does / why we need it:
实现了图片类型的附件缩略图生成和管理的新机制
实现依据 RFC:halo-dev/rfcs#24
使用缩略图前需要配置 externalUrl 才能生成
How to test it?
http://localhost:8090/apis/storage.halo.run/v1alpha1/thumbnails中存在一份记录记录
Which issue(s) this PR fixes:
Fixes #2387
Does this PR introduce a user-facing change?