New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chroma highlighting support (Hugo now use it) #94

Merged
merged 5 commits into from Nov 12, 2017

Conversation

Projects
None yet
3 participants
@badele
Contributor

badele commented Nov 8, 2017

No description provided.

@henryiii

This comment has been minimized.

Contributor

henryiii commented Nov 10, 2017

I was just about to make this change and make a PR! Thanks! 👍

@henryiii

This comment has been minimized.

Contributor

henryiii commented Nov 10, 2017

I've made a few improvements, such as a note in the README on activating Chroma support in the theme (it's default in Hugo!) and theming. I removed the highlight JS (not just the CSS) when Chroma is activated, and am using the same name for the css file as in the docs. The only comment I might suggest is a better default; the monokai theme is ugly (IMO) and doesn't match the normal default for this theme. I'm locally using manni for now.

For the moment, @badele , I'll make the PR to your branch.

@badele

This comment has been minimized.

Contributor

badele commented Nov 10, 2017

Thank @henryiii for you PR :)

@halogenica halogenica merged commit 4f7b301 into halogenica:master Nov 12, 2017

@halogenica

This comment has been minimized.

Owner

halogenica commented Nov 12, 2017

Thank you both very much! I also wanted to add this, I appreciate your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment