Permalink
Browse files

Creating release 1.2.3 with encoding fixes.

  • Loading branch information...
1 parent 68e1a15 commit 12df45ec8edef0727b3cec2ff6f9ba0d6fff305f @halostatue committed Apr 12, 2013
Showing with 30 additions and 5 deletions.
  1. +18 −0 History.rdoc
  2. +10 −3 README.rdoc
  3. +2 −2 lib/diff/lcs.rb
View
@@ -1,3 +1,21 @@
+== 1.2.3 / 2013-04-11
+
+* Bugs Fixed:
+ * The new encoding detection for diff output generation (added in 1.2.2)
+ introduced a bug if the left side of the comparison was the empty set.
+ Originally found in rspec/rspec-expectations#238 and
+ rspec/rspec-expectations#239. Jon Rowe developed a reasonable heuristic
+ (left side, right side, empty string literal) to avoid this bug.
+ https://github.com/rspec/rspec-expectations/pull/238
+ https://github.com/rspec/rspec-expectations/pull/239
+* There is a known issue with Rubinius in 1.9 mode reported in
+ rubinius/rubinius#2268 and demonstrated in the Travis CI builds. For all
+ other tested platforms, diff-lcs is considered stable. As soon as a suitably
+ small test-case can be created for the Rubinius team to examine, this will be
+ added to the Rubinius issue around this.
+ https://github.com/rubinius/rubinius/issues/2268
+ https://travis-ci.org/halostatue/diff-lcs/jobs/6241195
+
== 1.2.2 / 2013-03-30
* Bugs Fixed:
View
@@ -11,9 +11,16 @@ Diff::LCS computes the difference between two Enumerable sequences using the
McIlroy-Hunt longest common subsequence (LCS) algorithm. It includes utilities
to create a simple HTML diff output format and a standard diff-like tool.
-This is release 1.2.2, fixing a bug that prevented comparison of values that
-are not US-ASCII-compatible. Thanks to Jon Rowe for finding and providing most
-of the work behind this issue. This is a recommended release.
+This is release 1.2.3, fixing a bug in value comparison where the left side of
+the comparison was the empty set, preventing the detection of encoding. Thanks
+to Jon Rowe for fixing this issue. This is a strongly recommended release.
+
+*Note*: There is a known issue with Rubinius in 1.9 mode reported in
+{rubinius/rubinius#2268}[https://github.com/rubinius/rubinius/issues/2268] and
+demonstrated in the Travis CI builds. For all other tested platforms, diff-lcs
+is considered stable. As soon as a suitably small test-case can be created for
+the Rubinius team to examine, this will be added to the Rubinius issue around
+this.
== Synopsis
View
@@ -1,7 +1,7 @@
# -*- ruby encoding: utf-8 -*-
module Diff; end unless defined? Diff
-# = Diff::LCS 1.2.2
+# = Diff::LCS 1.2.3
#
# Computes "intelligent" differences between two sequenced Enumerables. This
# is an implementation of the McIlroy-Hunt "diff" algorithm for Enumerable
@@ -129,7 +129,7 @@ module Diff; end unless defined? Diff
# Common Subsequences</em>, CACM, vol.20, no.5, pp.350-353, May
# 1977, with a few minor improvements to improve the speed."
module Diff::LCS
- VERSION = '1.2.2'
+ VERSION = '1.2.3'
end
require 'diff/lcs/callbacks'

0 comments on commit 12df45e

Please sign in to comment.