Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix pruning of common sequences at start. #18

Merged
merged 1 commit into from

2 participants

@pck

Hello, just a small fix.
The code was originally correct but a bug was introduced after v1.1.3.
Thanks for providing this library!
Kind regards, Paul

@halostatue halostatue merged commit 28fc343 into from
@pck pck deleted the branch
@jperkin jperkin referenced this pull request from a commit in joyent/pkgsrc
taca Update ruby-diff-lcs to 1.2.4.
=== 1.2.4 / 2013-04-20

* Bugs fixed:
  * A bug was introduced after 1.1.3 when pruning common sequences at the start
    of comparison. Paul Kunysch (@pck) fixed this in pull request 18. Thanks!
    halostatue/diff-lcs#18
* The Rubinius (1.9 mode) bug in rubinius/rubinius#2268 has been fixed by the
  Rubinius team two days after it was filed. Thanks for fixing this so quickly!
  rubinius/rubinius#2268
* Switching to Raggi's hoe-gemspec2 for gemspec generation.

== 1.2.3 / 2013-04-11

* Bugs Fixed:
  * The new encoding detection for diff output generation (added in 1.2.2)
    introduced a bug if the left side of the comparison was the empty set.
    Originally found in rspec/rspec-expectations#238 and
    rspec/rspec-expectations#239. Jon Rowe developed a reasonable heuristic
    (left side, right side, empty string literal) to avoid this bug.
    rspec/rspec-expectations#238
    rspec/rspec-expectations#239
* There is a known issue with Rubinius in 1.9 mode reported in
  rubinius/rubinius#2268 and demonstrated in the Travis CI builds. For all
  other tested platforms, diff-lcs is considered stable. As soon as a suitably
  small test-case can be created for the Rubinius team to examine, this will be
  added to the Rubinius issue around this.
  rubinius/rubinius#2268
  https://travis-ci.org/halostatue/diff-lcs/jobs/6241195

== 1.2.2 / 2013-03-30

* Bugs Fixed:
  * Diff::LCS::Hunk could not properly generate a difference for comparison
    sets that are not US-ASCII-compatible because of the use of literal regular
    expressions and strings. Jon Rowe (JonRowe) found this in
    rspec/rspec-expectations#219 and provided a first pass implementation in
    diff-lcs#15. I've reworked it because of test failures in Rubinius when
    running in Ruby 1.9 mode. This coerces the added values to the encoding of
    the old dataset (as determined by the first piece of the old dataset).
    rspec/rspec-expectations#219
    halostatue/diff-lcs#15
* Adding Travis CI testing for Ruby 2.0.
33fb27e
@jperkin jperkin referenced this pull request from a commit in joyent/pkgsrc
taca Update ruby-diff-lcs to 1.2.4.
=== 1.2.4 / 2013-04-20

* Bugs fixed:
  * A bug was introduced after 1.1.3 when pruning common sequences at the start
    of comparison. Paul Kunysch (@pck) fixed this in pull request 18. Thanks!
    halostatue/diff-lcs#18
* The Rubinius (1.9 mode) bug in rubinius/rubinius#2268 has been fixed by the
  Rubinius team two days after it was filed. Thanks for fixing this so quickly!
  rubinius/rubinius#2268
* Switching to Raggi's hoe-gemspec2 for gemspec generation.

== 1.2.3 / 2013-04-11

* Bugs Fixed:
  * The new encoding detection for diff output generation (added in 1.2.2)
    introduced a bug if the left side of the comparison was the empty set.
    Originally found in rspec/rspec-expectations#238 and
    rspec/rspec-expectations#239. Jon Rowe developed a reasonable heuristic
    (left side, right side, empty string literal) to avoid this bug.
    rspec/rspec-expectations#238
    rspec/rspec-expectations#239
* There is a known issue with Rubinius in 1.9 mode reported in
  rubinius/rubinius#2268 and demonstrated in the Travis CI builds. For all
  other tested platforms, diff-lcs is considered stable. As soon as a suitably
  small test-case can be created for the Rubinius team to examine, this will be
  added to the Rubinius issue around this.
  rubinius/rubinius#2268
  https://travis-ci.org/halostatue/diff-lcs/jobs/6241195

== 1.2.2 / 2013-03-30

* Bugs Fixed:
  * Diff::LCS::Hunk could not properly generate a difference for comparison
    sets that are not US-ASCII-compatible because of the use of literal regular
    expressions and strings. Jon Rowe (JonRowe) found this in
    rspec/rspec-expectations#219 and provided a first pass implementation in
    diff-lcs#15. I've reworked it because of test failures in Rubinius when
    running in Ruby 1.9 mode. This coerces the added values to the encoding of
    the old dataset (as determined by the first piece of the old dataset).
    rspec/rspec-expectations#219
    halostatue/diff-lcs#15
* Adding Travis CI testing for Ruby 2.0.
c88fee3
@jperkin jperkin referenced this pull request from a commit in joyent/pkgsrc
taca Update ruby-diff-lcs to 1.2.4.
=== 1.2.4 / 2013-04-20

* Bugs fixed:
  * A bug was introduced after 1.1.3 when pruning common sequences at the start
    of comparison. Paul Kunysch (@pck) fixed this in pull request 18. Thanks!
    halostatue/diff-lcs#18
* The Rubinius (1.9 mode) bug in rubinius/rubinius#2268 has been fixed by the
  Rubinius team two days after it was filed. Thanks for fixing this so quickly!
  rubinius/rubinius#2268
* Switching to Raggi's hoe-gemspec2 for gemspec generation.

== 1.2.3 / 2013-04-11

* Bugs Fixed:
  * The new encoding detection for diff output generation (added in 1.2.2)
    introduced a bug if the left side of the comparison was the empty set.
    Originally found in rspec/rspec-expectations#238 and
    rspec/rspec-expectations#239. Jon Rowe developed a reasonable heuristic
    (left side, right side, empty string literal) to avoid this bug.
    rspec/rspec-expectations#238
    rspec/rspec-expectations#239
* There is a known issue with Rubinius in 1.9 mode reported in
  rubinius/rubinius#2268 and demonstrated in the Travis CI builds. For all
  other tested platforms, diff-lcs is considered stable. As soon as a suitably
  small test-case can be created for the Rubinius team to examine, this will be
  added to the Rubinius issue around this.
  rubinius/rubinius#2268
  https://travis-ci.org/halostatue/diff-lcs/jobs/6241195

== 1.2.2 / 2013-03-30

* Bugs Fixed:
  * Diff::LCS::Hunk could not properly generate a difference for comparison
    sets that are not US-ASCII-compatible because of the use of literal regular
    expressions and strings. Jon Rowe (JonRowe) found this in
    rspec/rspec-expectations#219 and provided a first pass implementation in
    diff-lcs#15. I've reworked it because of test failures in Rubinius when
    running in Ruby 1.9 mode. This coerces the added values to the encoding of
    the old dataset (as determined by the first piece of the old dataset).
    rspec/rspec-expectations#219
    halostatue/diff-lcs#15
* Adding Travis CI testing for Ruby 2.0.
e1fdaed
@shin-szk-engineering shin-szk-engineering referenced this pull request from a commit in szk-engineering/loremipsum
@shin-szk-engineering shin-szk-engineering