Ss3 compatibility #9

Merged
merged 9 commits into from Jan 21, 2013

Conversation

Projects
None yet
4 participants
@svandragt

Hi Hamish,
Please find enclosed an pull request containing initial ss3 compatibility fixes, and more flexible group matching code.

Currently developing a SilverStripe intranet solution that is using this in a Windows Active Directory setting, so will continue updating this where required.

@Weishaupt

This comment has been minimized.

Show comment Hide comment
@Weishaupt

Weishaupt Oct 24, 2012

Hey @svandragt you should add your changes to the CHANGELOG as well. Thank you for the work. I will try out if the branch works for me.

Hey @svandragt you should add your changes to the CHANGELOG as well. Thank you for the work. I will try out if the branch works for me.

@svandragt

This comment has been minimized.

Show comment Hide comment
@svandragt

svandragt Oct 24, 2012

Yeah no problem will do so in the next few days, and add (if) any further bugfixes.

Yeah no problem will do so in the next few days, and add (if) any further bugfixes.

@svandragt

This comment has been minimized.

Show comment Hide comment
@svandragt

svandragt Oct 29, 2012

It seems there is a problem with my repo or GitHub for Windows, when using my repo http://i.imm.io/JEC2.png. I'm waiting for response from GitHub on an email I sent them. Until then I cannot use this repo and therefore not move this on.

It seems there is a problem with my repo or GitHub for Windows, when using my repo http://i.imm.io/JEC2.png. I'm waiting for response from GitHub on an email I sent them. Until then I cannot use this repo and therefore not move this on.

@hamishcampbell

This comment has been minimized.

Show comment Hide comment
@hamishcampbell

hamishcampbell Nov 1, 2012

Owner

Hey thanks,

I've tagged the current release as ss-2.x so people can find the relevant commit for backwards compat.

Could you just fix up the whitespace in code/ExternalAuthenticator.php (groupObj method is strangely aligned) and update CHANGELOG, and I'll merge.

Thanks!

Owner

hamishcampbell commented Nov 1, 2012

Hey thanks,

I've tagged the current release as ss-2.x so people can find the relevant commit for backwards compat.

Could you just fix up the whitespace in code/ExternalAuthenticator.php (groupObj method is strangely aligned) and update CHANGELOG, and I'll merge.

Thanks!

@hamishcampbell

This comment has been minimized.

Show comment Hide comment
@hamishcampbell

hamishcampbell Nov 1, 2012

Owner

Also, method comments =D

Owner

hamishcampbell commented Nov 1, 2012

Also, method comments =D

@nathanbrauer

This comment has been minimized.

Show comment Hide comment
@nathanbrauer

nathanbrauer Jan 10, 2013

Updates?

Updates?

@svandragt

This comment has been minimized.

Show comment Hide comment
@svandragt

svandragt Jan 11, 2013

I just updated GitHub for Windows the 1.0.32 release fixes the problems reported earlier, therefore I can now use this repository once more. I will now start looking at the comments on this pull request and will update this pull request once this is done.

I just updated GitHub for Windows the 1.0.32 release fixes the problems reported earlier, therefore I can now use this repository once more. I will now start looking at the comments on this pull request and will update this pull request once this is done.

@nathanbrauer

This comment has been minimized.

Show comment Hide comment
@nathanbrauer

nathanbrauer Jan 14, 2013

Awesome! Looking forward to it!

Awesome! Looking forward to it!

@svandragt

This comment has been minimized.

Show comment Hide comment
@svandragt

svandragt Jan 17, 2013

Please find enclosed the fixes as requested. I'm using this code in production for our institution's SilverStripe websites. Sorry for the spelling mistake on the log message 'indendation fix'.

Please find enclosed the fixes as requested. I'm using this code in production for our institution's SilverStripe websites. Sorry for the spelling mistake on the log message 'indendation fix'.

hamishcampbell added a commit that referenced this pull request Jan 21, 2013

@hamishcampbell hamishcampbell merged commit 6188bf3 into hamishcampbell:master Jan 21, 2013

@hamishcampbell

This comment has been minimized.

Show comment Hide comment
@hamishcampbell

hamishcampbell Jan 21, 2013

Owner

Awesome, thanks!!

Owner

hamishcampbell commented Jan 21, 2013

Awesome, thanks!!

@hamishcampbell

This comment has been minimized.

Show comment Hide comment
@hamishcampbell

hamishcampbell Jan 21, 2013

Owner

PS added @svandragt as collaborator so you can push any fixes, etc 😄

Owner

hamishcampbell commented Jan 21, 2013

PS added @svandragt as collaborator so you can push any fixes, etc 😄

@svandragt

This comment has been minimized.

Show comment Hide comment
@svandragt

svandragt Jan 21, 2013

Thanks Hamish (love that name btw)

Thanks Hamish (love that name btw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment