Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacement for Haml::AttributeParser available? #1085

Closed
raxod502 opened this issue Sep 22, 2022 · 2 comments
Closed

Replacement for Haml::AttributeParser available? #1085

raxod502 opened this issue Sep 22, 2022 · 2 comments

Comments

@raxod502
Copy link

Getting this when upgrading from 5.x to 6.x of haml:

NameError: undefined method `available?' for class `Haml::AttributeParser'

I notice that, indeed, this method has been removed. What should we use instead?

The online docs (https://haml.info/docs/yardoc/Haml/AttributeParser.html), which I understand per #1064 is not updated for 6.x, suggests that available? should "return true if AttributeParser.parse can be used". Does the absence of this method mean that in haml 6.x we can always expect AttributeParser.parse to be available?
@raxod502 raxod502 mentioned this issue Sep 22, 2022
Merged
@k0kubun
Copy link
Member

k0kubun commented Sep 23, 2022

AttributeParser is designed for an optimization and I'm not sure if it's necessarily useful as a public API, but I'm okay with resurrecting this for now. Added this back at b3cdafd.

@k0kubun
Copy link
Member

k0kubun commented Sep 23, 2022

Released as v6.0.1.

raxod502 added a commit to raxod502/syntax_tree-haml that referenced this issue Sep 29, 2022
@raxod502
Revert "Assume that AttributeParser will always be available"
86ea684 
This reverts commit caf213b.

We can continue using the existing method in haml 6.0.1 per
haml/haml#1085.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@k0kubun @raxod502