Skip to content

ruby percentage notation fails to parse #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maland opened this issue Sep 29, 2022 · 1 comment
Closed

ruby percentage notation fails to parse #1096

maland opened this issue Sep 29, 2022 · 1 comment

Comments

@maland
Copy link

maland commented Sep 29, 2022

in an haml attribute like title, this works:

%p{ title: %{foo(#{some_local_variable})} }

and this as well:

%p{ title: "foo(#{some_local_variable})" }

but this does not:

%p{ title: %(foo(#{some_local_variable})) }

this raises:

(eval):1: unterminated string meets end of file
%(foo(#)
^

imho all examples are right syntax

@k0kubun k0kubun closed this as completed in e3bd326 Oct 3, 2022
@k0kubun
Copy link
Member

k0kubun commented Oct 3, 2022

This is technically not this gem's issue but Temple's, but I fixed this in v6.0.4 on Haml's side as it seems like our fix isn't going to be merged to Temple soon.

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Oct 12, 2022
https://build.opensuse.org/request/show/1010035
by user coolo + dimstar_suse
updated to version 6.0.6
 see installed CHANGELOG.md
  ## 6.0.6

  * Prevent CRuby from accidentally using the Ruby implementation fallback
    * Reversing what v6.0.3 and v6.0.4 did, but still supporting Wasm.

  ## 6.0.5

  * Resurrect `#haml_object_ref` support in an object reference [#1097](haml/haml#1097)
    * This was removed in 6.0.0, and added back in this version.
  * Stop warning `remove_whitespace: true` option.

  ## 6.0.4

  Released on October 2, 2022
  ([diff](haml/haml@v6.0.3...v6.0.4)).

  * Fix a parse failure of `%` in attributes [#1096](haml/haml#1096)
  * Add another fallback from C to Ruby for Wasm.

  ## 6.0.3

  Released on September 28, 2022
  ([diff](https://github.com/h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants