New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html2haml requires hpricot but does not declare it as dependency #504

Closed
alexeymuranov opened this Issue Mar 30, 2012 · 7 comments

Comments

Projects
None yet
3 participants
@alexeymuranov

alexeymuranov commented Mar 30, 2012

Hello, am i missing something, or is hpricot required but not declared as dependency of html2haml?

§ gem install haml
Successfully installed haml-3.1.4
1 gem installed
Installing ri documentation for haml-3.1.4...
Installing RDoc documentation for haml-3.1.4...
§ html2haml
LoadError: cannot load such file -- hpricot
  Use --trace for backtrace.
§ gem install hpricot
Fetching: hpricot-0.8.6.gem (100%)
Building native extensions.  This could take a while...
Successfully installed hpricot-0.8.6
1 gem installed
Installing ri documentation for hpricot-0.8.6...
Installing RDoc documentation for hpricot-0.8.6...
§ html2haml
^CInterrupt: 
  Use --trace for backtrace.

Thanks.

@norman

This comment has been minimized.

Member

norman commented Apr 19, 2012

I think it's not currently added as a dependency because not everybody needs html2haml, and hpricot has a C extension which can sometimes complicate installation of the gem.

Perhaps it would be more user-friendly to rescue from LoadError and display a more informative message telling people to how to install the gem. It's probably also a good idea to at least add it as a development dependency.

@norman

This comment has been minimized.

Member

norman commented Apr 28, 2012

Since my previous comment I noticed it's already listed as a development dependency. I'll add it as a full dependency if I can verify that it works fine on Windows, JRuby and Rubinius.

@alexeymuranov

This comment has been minimized.

alexeymuranov commented Apr 28, 2012

Thanks.

@norman

This comment has been minimized.

Member

norman commented Apr 28, 2012

I'm going to close this in favor of #479 for now. See also the discussion in #512.

@norman norman closed this Apr 28, 2012

@ghost

This comment has been minimized.

ghost commented Jun 15, 2012

The user experience should come first. It should just work -- or at the minimum, tell us what to do.

@ghost

This comment has been minimized.

ghost commented Jun 15, 2012

I also ran into this -- I immediately tried installing the hpricot gem, but that didn't fix it.

@ghost

This comment has been minimized.

ghost commented Jun 15, 2012

Ah, I see that you are working on this here: https://github.com/haml/html2haml/issues/1 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment