Skip to content

Silence some more warnings #530

Closed
wants to merge 2 commits into from

2 participants

@mattwildig
Haml member

More on issue #515.

I’ve deliberately left the indentation alone on the erb template, so that it’s easier to see what’s changed.

It’s a fairly “brute force” fix, in that there may be a simpler way to combine the various conditionals to generate the correct code, but it’s a maze of twisty little passages, all alike.

mattwildig added some commits May 9, 2012
@mattwildig mattwildig Silence unused variable warning.
Haml does some magic with eval and binding, so _erbout isn't really
unused. In order to silence the warning it needs to be used in way that
can be seen, so use to_s as a no-op.
60ec4c5
@mattwildig mattwildig Silence warnings in generated code. a68a96b
@norman
Haml member
norman commented May 9, 2012

I admire your courage, that code is quite difficult to understand. :) Will take a look at this soon - thanks a lot for the time you've been putting into Haml.

@norman
Haml member
norman commented May 23, 2012

Pulled, thanks!

@norman norman closed this May 23, 2012
@mattwildig
Haml member

I noticed this conflicted with some other work you did, I assume you were able to resolve it okay?

@norman
Haml member
norman commented May 23, 2012

Yup, no problem at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.