Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word break element is self-closing #727

Merged
merged 1 commit into from Dec 10, 2013
Merged

Conversation

NathanielWroblewski
Copy link

@NathanielWroblewski NathanielWroblewski commented Nov 30, 2013

screen shot 2013-11-29 at 9 49 42 pm

@coveralls
Copy link

@coveralls coveralls commented Nov 30, 2013

Coverage Status

Changes Unknown when pulling 31604f6 on NathanielWroblewski:master into * on haml:master*.

@norman
Copy link
Contributor

@norman norman commented Dec 4, 2013

Thanks for this. I looked into it a bit more and as it turns out there are several more elements that we will need to add too.

The list of all void or self-closing elements is currently:

HTML5

  • area
  • base
  • br
  • col
  • command
  • embed
  • hr
  • img
  • input
  • keygen
  • link
  • meta
  • param
  • source
  • track
  • wbr

HTML4

  • basefont
  • frame
  • isindex

HTML 5.1

  • menuitem

So the list of elements we currently need to add to both Haml stable and Haml master is:

  • command
  • embed
  • keygen
  • source
  • track
  • menuitem
  • wbr

Would you mind adding these to your pull request? I can then pull into master and cherry-pick the changes into stable too.

@NathanielWroblewski
Copy link
Author

@NathanielWroblewski NathanielWroblewski commented Dec 4, 2013

I'd be happy to add them! Would you like me to add any specs for these, or is the current coverage satisfactory? Also, I'm not super familiar with the code base, so let me know if they need to be added anywhere else as well. Thanks!

@norman
Copy link
Contributor

@norman norman commented Dec 4, 2013

It should be fine to just add them in the same place as you added wbr. The test coverage should be fine too, since the feature is already tested and this is really just a change to the default configuration data.

@coveralls
Copy link

@coveralls coveralls commented Dec 5, 2013

Coverage Status

Coverage remained the same when pulling 804be4c on NathanielWroblewski:master into 40d3e7a on haml:master.

@NathanielWroblewski
Copy link
Author

@NathanielWroblewski NathanielWroblewski commented Dec 5, 2013

Updated to the complete list you provided. Also alphabetized the list so that it is easier to locate elements as the number of self-closing tags grows.

@norman
Copy link
Contributor

@norman norman commented Dec 10, 2013

Thanks!

norman added a commit that referenced this issue Dec 10, 2013
Added more default closing elements.
@norman norman merged commit 1ed9f04 into haml:master Dec 10, 2013
1 check passed
@NathanielWroblewski
Copy link
Author

@NathanielWroblewski NathanielWroblewski commented Dec 13, 2013

Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants