Skip to content

Conversation

@stanhu
Copy link
Contributor

@stanhu stanhu commented Jul 16, 2015

The leading whitespace match and back reference added significant overhead in
certain cases, sometimes leading to render times taking minutes. In one case,
the render time dropped from 2+ minutes to 200 milliseconds.

Closes #849

The leading whitespace match and back reference added significant overhead in
certain cases, sometimes leading to render times taking minutes. In some cases,
the render time dropped from 2+ minutes to 200 milliseconds.

Closes haml#849
@stanhu
Copy link
Contributor Author

stanhu commented Jul 18, 2015

@norman, would you mind reviewing this one? The GitLab project could take advantage of having this changed merged in soon. Thank you.

@norman
Copy link
Contributor

norman commented Jul 20, 2015

Thanks very much for working on this. I'm traveling right now and will look
at it as soon as I can. I see no reason not to pull this and release a new
4.0.x version right away, as long as it doesn't break anything.
On Sat, Jul 18, 2015 at 09:44 Stan Hu notifications@github.com wrote:

@norman https://github.com/norman, would you mind reviewing this one?
The GitLab project could take advantage of having this changed merged in
soon. Thank you.


Reply to this email directly or view it on GitHub
#850 (comment).

@stanhu
Copy link
Contributor Author

stanhu commented Jul 29, 2015

Thanks, @norman. Just checking in to see if you're back from your travels and had time to review.

@norman
Copy link
Contributor

norman commented Aug 10, 2015

I've just merged this change into both master and stable, and released Haml 4.0.7. Thanks @stanhu for your work!

@norman norman closed this Aug 10, 2015
@stanhu
Copy link
Contributor Author

stanhu commented Aug 10, 2015

Thanks @norman! We're upgrading to 4.0.7 now!

dzaporozhets added a commit to gitlabhq/gitlabhq that referenced this pull request Aug 11, 2015
Bump Haml to 4.0.7 to speed up textarea rendering

The current regexp caused long load times when textarea blocks were surrounded by whitespace. This fix has been submitted to the Haml library and passes tests there:

haml/haml#850

Closes #1987

See merge request !984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants