Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-freeze TempleEngine precompiled string literals #983

Merged
merged 1 commit into from Mar 10, 2018

Conversation

Projects
None yet
2 participants
@wjordan
Copy link
Contributor

commented Mar 1, 2018

Fixes #982.
This PR maintains public-API compatibility in Haml::TempleEngine#precompiled_with_return_value and precompiled_with_ambles, returning mutable strings as expected by tilt's Haml template implementation (which calls #force_encoding on the result).

unfreeze TempleEngine precompiled string literals
Maintain backwards-compatibility in public API.
@k0kubun

This comment has been minimized.

Copy link
Member

commented Mar 10, 2018

Ideally mutating #precompiled source code would not make to me. But freezing the returned value of public interface is definitely the breaking change, and I agree that it was unwanted side effect of #967. Thanks to catch this.

@k0kubun k0kubun merged commit 9856684 into haml:master Mar 10, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@k0kubun

This comment has been minimized.

Copy link
Member

commented Mar 10, 2018

Probably we should have a test that ensures their returned values can be mutated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.