New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pointer events bug falsely detecting multiple pointers #665

Merged
merged 1 commit into from Sep 16, 2014

Conversation

Projects
None yet
2 participants
@jbrantly
Contributor

jbrantly commented Sep 11, 2014

It is possible for IE to fire a "down" event without a corresponding "up"
event. If this happens, a new "down" event will be falsely added as an
additional pointer. This commit first makes sure the pointer from the
down event is not already in the store before adding it (based on
pointerId).

Fixes #664

Fixing pointer events bug falsely detecting multiple pointers
It is possible for IE to fire a "down" event without a corresponding "up"
event. If this happens, a new "down" event will be falsely added as an
additional pointer. This commit first makes sure the pointer from the
down event is not already in the store before adding it (based on
pointerId).

Fixes #664

jtangelder added a commit that referenced this pull request Sep 16, 2014

Merge pull request #665 from jbrantly/issue-664-pointer-events-bug
Fixing pointer events bug falsely detecting multiple pointers

@jtangelder jtangelder merged commit 163ead7 into hammerjs:master Sep 16, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jtangelder

This comment has been minimized.

Show comment
Hide comment
@jtangelder

jtangelder Sep 16, 2014

Member

Great, thanks.

Member

jtangelder commented Sep 16, 2014

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment