fixed normalize_chromosome, made all_feature_values private #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d test for Genome.contigs()
| @@ -41,17 +41,20 @@ def normalize_chromosome(c): | |||
| if result.startswith("chr"): | |||
| result = result[3:] | |||
|
|
|||
| # just in case someone is being lazy, capitalize "X" and "Y" | |||
There was a problem hiding this comment.
And M/MT? Can you add that to clarify?
|
LGMT % minor comment |
iskandr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in
normalize_chromosomewhere lowercase mitochondrial names were sneaking through.Also fixed #139 by making
Genome.all_feature_valuesprivate.Added unit test for newly added
Genome.contigs()This change is