Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade to Hanami 2 #15

Draft
wants to merge 61 commits into
base: main
Choose a base branch
from
Draft

Conversation

cllns
Copy link
Member

@cllns cllns commented Jul 1, 2021

Still a work in progress.

I used https://github.com/hanami/hanami-2-application-template to base this work off, so there are extra things in this repo from that.

This PR currently uses some GitHub sources in the Gemfile, to get not-yet-released code.

I tried to break the commits up into reasonable chunks, but for many of them the tests just don't pass because there's a lot of configuration that needs to change.

I may rewrite these commits and force-push to rewrite some commit history, so be aware of that.

We will be using this to write an "Upgrading from Hanami 1 to Hanami 2" guide.

cllns added 30 commits June 30, 2021 14:30
Also add .ruby-version file (for Ruby 3)
We should rename it to CSRF (since it's an acronym now in dry-inflector 0.2.1) but
CSRF protecting will be brought into hanami and out of the app, so it's not a high priority
Specifically:
- dry-system
- dry-configurable
- dry-inflector
This was temporarily duplicated but it was brought into hanami/controller
due to inflector acronym issues

See hanami/hanami-2-application-template#33
@cllns
Copy link
Member Author

cllns commented Dec 4, 2021

Just moved the repositories over into the Main slice (from the project Bookshelf namespace), as the new conventions suggest. Also cleaned up some other minor things.

No need to use the slice, in preparation for changing it to an instance double
We take a pretty hard stance against monkey patching so we should be consistent.
Skipping  doesn't add much, and it's more explicit this way.
@cllns cllns force-pushed the work-in-progress/upgrade-to-hanami-2 branch from 6ad0f57 to 6017e85 Compare January 11, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant