Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move storing of errors to utility for reusing #298

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@lfidnl
Copy link
Contributor

lfidnl commented Oct 17, 2019

@jodosha hello!
This is one more attempt of hanami/hanami#1014 :) Sorry, but I'm not sure to made it correct and place this utility in right place. If it is true, please, correct me and I will make appropriate changes.

@jodosha jodosha self-assigned this Oct 18, 2019
@jodosha jodosha added the refactoring label Oct 18, 2019
@jodosha jodosha added this to the v1.3.3 milestone Oct 18, 2019
@jodosha jodosha self-requested a review Oct 18, 2019
Copy link
Member

jodosha left a comment

@lfidnl Thanks for the patience about this change. If you feel good, would you please do an extra change that I left as inline comment? Thanks! 👍

lib/hanami/action/throwable.rb Outdated Show resolved Hide resolved
@lfidnl lfidnl force-pushed the lfidnl:rack_error_processing branch from 1472090 to e9f4b5a Nov 22, 2019
@lfidnl

This comment has been minimized.

Copy link
Contributor Author

lfidnl commented Nov 22, 2019

@jodosha I made changes according to your comment

@jodosha jodosha merged commit 4960f66 into hanami:master Jan 14, 2020
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 99.61%)
Details
codecov/project 99.62% (+<.01%) compared to 29ab743
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.