Merge pull request #244 from lotus/fix-lotusrc-do-not-pollute-env

Don't let .lotusrc read to pollute ENV

lib/lotus/lotusrc.rb

@@ -1,5 +1,5 @@
 require 'pathname'
-require 'dotenv'
+require 'dotenv/parser'
 
 module Lotus
   # Create and read the .lotusrc file in the root of the application
@@ -93,8 +93,9 @@ def initialize(root, options = {})
     #    # => { architecture: 'application', test: 'rspec', template: 'slim' }
     def read
       if exists?
-        lotusrc_options = Dotenv.load path_file
-        Utils::Hash.new(lotusrc_options).symbolize!
+        Utils::Hash.new(
+          Dotenv::Parser.call(content)
+        ).symbolize!
       end
     end
 
@@ -142,5 +143,9 @@ def exists?
     def path_file
       @root.join FILE_NAME
     end
+
+    def content
+      path_file.read
+    end
   end
 end

lotusrb.gemspec

@@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'lotus-view',       '~> 0.4'
   spec.add_dependency 'lotus-helpers',    '~> 0.2'
   spec.add_dependency 'shotgun',          '~> 0.9'
-  spec.add_dependency 'dotenv',           '~> 1.0'
+  spec.add_dependency 'dotenv',           '~> 2.0'
   spec.add_dependency 'thor',             '~> 0.19'
 
   spec.add_development_dependency 'bundler',   '~> 1.6'

test/lotusrc_test.rb

@@ -30,6 +30,15 @@
         options[:test].must_equal 'minitest'
         options[:template].must_equal 'erb'
       end
+
+      # Bug: https://github.com/lotus/lotus/issues/243
+      it "doesn't pollute ENV" do
+        @lotusrc.read
+
+        ENV.key?('architecture').must_equal false
+        ENV.key?('test').must_equal false
+        ENV.key?('template').must_equal false
+      end
     end
 
     describe "file doesn't exist" do