New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hanami beta needs gemfile installed #838

Closed
dsisnero opened this Issue Oct 3, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@dsisnero

dsisnero commented Oct 3, 2017

bin\hanami in beta requires bundler and uses Bundle.require. The gem doesn't include a Gemfile so the command fails on windows

c:\Dominic\programming\ruby\hanami\hanami-1.1.0.beta2\bin>hanami new bookshelf
Bundler::GemfileNotFound: Could not locate Gemfile or .bundle/ directory
dir

c:\Dominic\programming\ruby\hanami\hanami-1.1.0.beta2\bin>gem list hanami

*** LOCAL GEMS ***

hanami (1.1.0.beta2)
hanami-assets (1.1.0.beta2)
hanami-cli (0.1.0.beta2)
hanami-controller (1.1.0.beta2)
hanami-helpers (1.1.0.beta2)
hanami-mailer (1.1.0.beta2)
hanami-router (1.1.0.beta2)
hanami-utils (1.1.0.beta2)
hanami-validations (1.1.0.beta2)
hanami-view (1.1.0.beta2)

From an unpacked hanami -- gem unpack hanami

Directory of c:\Dominic\programming\ruby\hanami\hanami-1.1.0.beta2

10/03/2017 04:59 PM

.
10/03/2017 04:59 PM ..
10/03/2017 04:59 PM bin
10/03/2017 04:59 PM 24,064 CHANGELOG.md
10/03/2017 04:59 PM 3,230 CODE_OF_CONDUCT.md
10/03/2017 04:59 PM 9,163 FEATURES.md
10/03/2017 04:59 PM 1,792 hanami.gemspec
10/03/2017 04:59 PM lib
10/03/2017 04:59 PM 1,071 LICENSE.md
10/03/2017 04:59 PM 4,694 README.md
6 File(s) 44,014 bytes
4 Dir(s) 8,635,719,680 bytes free

@jodosha jodosha self-assigned this Oct 4, 2017

@jodosha jodosha added the bug label Oct 4, 2017

@jodosha jodosha added this to the v1.1.0 milestone Oct 4, 2017

@jodosha

This comment has been minimized.

Show comment
Hide comment
@jodosha

jodosha Oct 4, 2017

Member

@dsisnero thanks for reporting it. I'm working on a fix.

Member

jodosha commented Oct 4, 2017

@dsisnero thanks for reporting it. I'm working on a fix.

@jodosha

This comment has been minimized.

Show comment
Hide comment
@jodosha

jodosha Oct 4, 2017

Member

Another case reported by @malin-as in chat:

$ echo '2.4.2' > .ruby-version
$ echo 'hanami-beta2' > .ruby-gemset
$ cd .
ruby-2.4.2 - #gemset created /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2
ruby-2.4.2 - #generating hanami-beta2 wrappers..........
$ gem install hanami --pre
[...]
28 gems installed

$ hanami new bookshelf
/home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:212:in `rescue in root': Could not locate Gemfile or .bundle/ directory (Bundler::GemfileNotFound)
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:208:in `root'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:78:in `bundle_path'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:505:in `configure_gem_path'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:493:in `configure_gem_home_and_path'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:64:in `configure'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:128:in `definition'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:95:in `setup'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:108:in `require'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/hanami-1.1.0.beta2/bin/hanami:5:in `<top (required)>'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/bin/hanami:23:in `load'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/bin/hanami:23:in `<main>'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/bin/ruby_executable_hooks:15:in `eval'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/bin/ruby_executable_hooks:15:in `<main>'
Member

jodosha commented Oct 4, 2017

Another case reported by @malin-as in chat:

$ echo '2.4.2' > .ruby-version
$ echo 'hanami-beta2' > .ruby-gemset
$ cd .
ruby-2.4.2 - #gemset created /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2
ruby-2.4.2 - #generating hanami-beta2 wrappers..........
$ gem install hanami --pre
[...]
28 gems installed

$ hanami new bookshelf
/home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:212:in `rescue in root': Could not locate Gemfile or .bundle/ directory (Bundler::GemfileNotFound)
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:208:in `root'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:78:in `bundle_path'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:505:in `configure_gem_path'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:493:in `configure_gem_home_and_path'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:64:in `configure'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:128:in `definition'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:95:in `setup'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/bundler-1.15.4/lib/bundler.rb:108:in `require'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/gems/hanami-1.1.0.beta2/bin/hanami:5:in `<top (required)>'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/bin/hanami:23:in `load'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/bin/hanami:23:in `<main>'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/bin/ruby_executable_hooks:15:in `eval'
        from /home/malina/.rvm/gems/ruby-2.4.2@hanami-beta2/bin/ruby_executable_hooks:15:in `<main>'
@jodosha

This comment has been minimized.

Show comment
Hide comment
@jodosha

jodosha Oct 4, 2017

Member

Fixed by #839

Member

jodosha commented Oct 4, 2017

Fixed by #839

@jodosha jodosha closed this Oct 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment