Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Hanami::Action::ApplicationConfiguration for actions configuration #1068

Merged

Conversation

timriley
Copy link
Member

This changes the approach for exposing application-level action config. Instead of taking responsibility for building up the config object at the framework level, instead defer in full to hanami-controller, and allow it to provide its own appropriate object for application-level configuration, in this case, the new Hanami::Action::ApplicationConfiguration created in hanami/controller#321 (the counterpart PR to this one).

This gets us closer to the ideal framework extension approach, too – less hard-coding at the framework level, more delegation to the integrating extensions. Eventually we'll provide some extension point for other gems to provide their own application-level config, but until then, this gets us close to that model in spirit 😄

This allows hanami-controller to provide the full range of supporting configuration required for its application integration behavior
@timriley timriley merged commit 2360272 into unstable Jul 16, 2020
@timriley timriley deleted the enhancement/unstable/use-action-application-configuration branch July 16, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants