Use Hanami::Action::ApplicationConfiguration for actions configuration #1068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the approach for exposing application-level action config. Instead of taking responsibility for building up the config object at the framework level, instead defer in full to hanami-controller, and allow it to provide its own appropriate object for application-level configuration, in this case, the new
Hanami::Action::ApplicationConfiguration
created in hanami/controller#321 (the counterpart PR to this one).This gets us closer to the ideal framework extension approach, too – less hard-coding at the framework level, more delegation to the integrating extensions. Eventually we'll provide some extension point for other gems to provide their own application-level config, but until then, this gets us close to that model in spirit 😄