Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slice Rack middleware #1234

Merged
merged 10 commits into from Nov 5, 2022
Merged

Fix slice Rack middleware #1234

merged 10 commits into from Nov 5, 2022

Conversation

jodosha
Copy link
Member

@jodosha jodosha commented Oct 31, 2022

Fix

Ensure to properly mount Rack middleware in routing scope and slice.


https://trello.com/c/4otUMpaN

@jodosha jodosha added this to the v2.0.0 milestone Oct 31, 2022
@jodosha jodosha self-assigned this Oct 31, 2022
@jodosha jodosha marked this pull request as ready for review November 3, 2022 08:19
Copy link
Member

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving because the specs passed...otherwise I'm unable to review because I've no idea how things work "on the other side" 😅

Copy link
Member

@timriley timriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Masterful work, @jodosha! I'm delighted with the end result here — this is such a powerful feature for Hanami!

From a quick glance at #1234, is it true that the other side of this work was mostly relocating code from hanami-api to hanami-router so that it could become accessible to us here in the hanami gem too?

Certainly having the Rack::Builder detail move outside of hanami and become a concern of Hanami::Middleware::App seems a win as well.

Anyway, very happy to see this go in 👍🏼

@jodosha
Copy link
Member Author

jodosha commented Nov 5, 2022

@timriley Yes, we had the chance to extract code from hanami-api, which was the first gem to have this feature.

@jodosha jodosha merged commit 389e246 into main Nov 5, 2022
@jodosha jodosha deleted the fix-slice-middlewares branch November 5, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants