Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Hanami application router #192

Merged
merged 7 commits into from Nov 26, 2019

Conversation

@timriley
Copy link
Member

timriley commented Nov 3, 2019

Changes required for the new application router to work (as described in hanami/hanami#1019).

timriley added 3 commits Nov 3, 2019
@timriley

This comment has been minimized.

Copy link
Member Author

timriley commented Nov 3, 2019

I need to update tests for this but I wanted to open a PR first as a way to link these changes together.

@timriley timriley mentioned this pull request Nov 3, 2019
8 of 15 tasks complete
timriley added 2 commits Nov 13, 2019
This was moved back into Hanami::Application::Router
@jodosha jodosha added this to the v2.0.0 milestone Nov 20, 2019
@jodosha jodosha added the enhancement label Nov 20, 2019
timriley and others added 2 commits Nov 16, 2019
This closes off the possibility of extending its behavior (e.g. it makes it impossible to add the "use" middleware declarations in Hanami::Application::Router)
@timriley timriley force-pushed the hanami-application-router-support branch from 136f4cd to 9fa48a9 Nov 23, 2019
@timriley timriley merged commit d42a54e into unstable Nov 26, 2019
8 checks passed
8 checks passed
ci/circleci: ruby-2.5 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.27%)
Details
codecov/project Absolute coverage decreased by -0.27% but relative coverage increased by +2.72% compared to 88670ec
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@timriley timriley deleted the hanami-application-router-support branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.