Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply singular for snake_cased words #340

Merged
merged 4 commits into from Sep 11, 2019

Conversation

@mauromorales
Copy link
Contributor

commented Aug 7, 2019

I'm super new to hanami and all its ecosystem, this PR is my naive approach at how I'd solve the problem of handling snake cased words which are part of the special singulars/plurals e.g. control_exercises.

Please give me some feedback and I'll be happy to apply to the best of my knowledge

fixes #339

@jodosha jodosha changed the title Apply singular for camel cased words Apply singular for snake_cased words Aug 8, 2019

@jodosha
Copy link
Member

left a comment

@mauromorales Thanks for this PR, can you please make sure to address Rubocop issues, and to add a test for .pluralize as well? I left other inline comments. Thank you! 👍

spec/unit/hanami/utils/string_spec.rb Outdated Show resolved Hide resolved
lib/hanami/utils/inflector.rb Outdated Show resolved Hide resolved
lib/hanami/utils/inflector.rb Outdated Show resolved Hide resolved

@jodosha jodosha self-assigned this Aug 8, 2019

@jodosha jodosha added the fix label Aug 8, 2019

@jodosha jodosha self-requested a review Aug 8, 2019

@mauromorales

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

@jodosha all changes you requested should be done by now, please have a look and let me know if you have any feedback, thanks

@jodosha jodosha added this to the v1.3.3 milestone Sep 11, 2019

@jodosha
Copy link
Member

left a comment

@mauromorales Thanks for this second iteration. On Friday, we'll release a new version containing this patch.

@jodosha jodosha merged commit 4994146 into hanami:master Sep 11, 2019

4 checks passed

codecov/patch 100% of diff hit (target 99.41%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +0.58% compared to 2cc692f
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauromorales mauromorales deleted the mauromorales:singularize_composed_words branch Sep 13, 2019

@mauromorales mauromorales restored the mauromorales:singularize_composed_words branch Sep 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.