Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error of logger's filter when input have closed Tempfile #342

Merged
merged 3 commits into from Oct 8, 2019

Conversation

@lfidnl
Copy link
Contributor

commented Sep 23, 2019

Hello.

I faced up with issue during upload a file to hanami app. Application works fine, but logger raise IOError: closed stream. This happens because logger's filter tries to navigate through closed Tempfile.

@jodosha jodosha self-assigned this Oct 4, 2019
@jodosha jodosha added bug fix labels Oct 4, 2019
Copy link
Member

left a comment

@lfidnl Thanks for this PR. The build fails for JRuby 9.1 and 9.2, it looks like there is a difference between MRI and JRuby. See https://ci.hanamirb.org/hanami/utils/401/5/3

Could you please have a look at it? Thanks.

@lfidnl lfidnl force-pushed the lfidnl:logger_filter_with_tempfile branch from 8ceab7d to 25a66ae Oct 4, 2019
@lfidnl

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

@jodosha hello! I've fixed it

jodosha added 2 commits Oct 8, 2019
…nl/utils into lfidnl-logger_filter_with_tempfile
@jodosha jodosha added this to the v1.3.5 milestone Oct 8, 2019
@jodosha jodosha self-requested a review Oct 8, 2019
@jodosha
jodosha approved these changes Oct 8, 2019
Copy link
Member

left a comment

@lfidnl Thanks for this fix! 👍

@jodosha jodosha merged commit f108020 into hanami:master Oct 8, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 99.41%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +0.58% compared to d07cfc1
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.