Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rubocop to version 0.77.0 #352

Merged
merged 2 commits into from Nov 29, 2019

Conversation

@depfu
Copy link
Contributor

depfu bot commented Nov 28, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.76.0 → ~> 0.77.0) · Repo · Changelog

Release Notes

0.77.0

Bug fixes

  • #7493: Fix Style/RedundantReturn to inspect conditional constructs that are preceded by other statements. (@buehmann)
  • #7509: Fix Layout/SpaceInsideArrayLiteralBrackets to correct empty lines. (@ayacai115)
  • #7517: Style/SpaceAroundKeyword allows :: after super. (@ozydingo)
  • #7515: Fix a false negative for Style/RedundantParentheses when calling a method with safe navigation operator. (@koic)
  • #7477: Fix line length autocorrect for semicolons in string literals. (@maxh)
  • #7522: Fix a false-positive edge case (n % 2 == 2) for Style/EvenOdd. (@buehmann)

Changes

  • #7077: (Breaking) Further standardisation of cop names. (@scottmatthewman)
  • #7469: (Breaking) Replace usages of the terms Whitelist and Blacklist with better alternatives. (@koic)
  • #7502: Remove SafeMode module. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 70 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu depfu bot added the depfu label Nov 28, 2019
@jodosha jodosha self-assigned this Nov 29, 2019
@jodosha jodosha added this to the v1.3.6 milestone Nov 29, 2019
@jodosha jodosha merged commit 143c1c4 into master Nov 29, 2019
12 checks passed
12 checks passed
ci/circleci: jruby-9.1 Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.3 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing bdd7891...be591ce
Details
codecov/project 99.41% remains the same compared to bdd7891
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@depfu depfu bot deleted the depfu/update/rubocop-0.77.0 branch Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.