Solves duplicate points and triangle errors #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By changing the triangulate function, it solves - 'unable to triangulate polygons' - 'it could not exturde geometry, it can be because of duplicated point of svg.'
|
Hey @xuv awesome! :) didn't know about this solution at all. Thank you so much! ( I might rearrange folder structure later, makng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @hanbyul-here
Did two things here:
duplicate pointsandtriangulateerrors from Threejs. So I dug up a little. This issue helped me solve it. I implemented theearcutsolution from this repo. Now we have a clean console. And normally all objects and path should be created correctly. Probably in future versions, Threejs will implement these solution in future releases.Hope this suits you.